allow multiple easyconfigs with same name if they differ by CUDA version included in versionsuffix#17289
Merged
boegel merged 1 commit intoeasybuilders:developfrom Feb 10, 2023
Conversation
Add `CUDA` to `versionsuffix_deps` next to `CUDAcore` as newer toolchains don't use `CUDAcore`.
1 task
boegel
changed the title
Member
|
@Flamefire Thanks, can you sync #17272 now that this is merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
CUDAtoversionsuffix_depsnext toCUDAcoreas newer toolchains don't useCUDAcore.Tested locally on top of #17272 : Before
test_dep_versions_per_toolchain_generationfails, after this PR it succeeds.