Skip to content

replace useless test step for simint 0.7 with (lightweight) sanity check command#17044

Merged
boegel merged 3 commits intoeasybuilders:developfrom
sassy-crick:20230104115150_new_pr_simint07
Jan 4, 2023
Merged

replace useless test step for simint 0.7 with (lightweight) sanity check command#17044
boegel merged 3 commits intoeasybuilders:developfrom
sassy-crick:20230104115150_new_pr_simint07

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Jan 4, 2023

(created using eb --new-pr)

This is a bug-fix for PR #16886 which has two problems:

  • The test job is not running as intended. This is fixed with this PR. A short test job is running per default, all tests jobs can be optionally run by removing the respective comments. Furthermore a message will be printed in the log file to check the test results manually.
  • Accidentally the old EasyConfig file simint-0.7-GCCcore-11.2.0-lmax-5-vec-avx-psi4.eb was not removed. Please remove that file so it is not in the upcoming release version.

Apologies for these issues.

@sassy-crick sassy-crick changed the title Fix so short test job is running, with all tests jobs are provided as well {chem}[GCC/11.2.0] simint v0.7 Bug Fix of #16886 Jan 4, 2023
@sassy-crick sassy-crick added this to the next release (4.7.0) milestone Jan 4, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 4, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17044 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17044 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9935

Test results coming soon (I hope)...

Details

- notification for comment with ID 1370890687 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title {chem}[GCC/11.2.0] simint v0.7 Bug Fix of #16886 replace useless test step for simint 0.7 with (lightweight) sanity check command Jan 4, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 4, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3130.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/48716d4211d1a128beaaeb142627aeec for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3c1fbb80f91f3aebaccd1e1080b86d6c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 4, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3569.doduo.os - Linux RHEL 8.6, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/b7a380f404bc5bdc7c803a0aea76854e for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 4, 2023

Going in, thanks @sassy-crick!

@boegel boegel merged commit 28c1331 into easybuilders:develop Jan 4, 2023
@sassy-crick sassy-crick deleted the 20230104115150_new_pr_simint07 branch January 4, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants