Skip to content

update easyconfigs to use SYSTEM template constant instead of True in dependencies#16386

Merged
boegel merged 7 commits intoeasybuilders:developfrom
jfgrimm:switch-true-to-system
Oct 11, 2022
Merged

update easyconfigs to use SYSTEM template constant instead of True in dependencies#16386
boegel merged 7 commits intoeasybuilders:developfrom
jfgrimm:switch-true-to-system

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Oct 11, 2022

see #16330 and #16384

for reference, the substitution pattern used: sed -i "s|', True)|', SYSTEM)|g"
haven't spotted any cases where this caused an issue

@jfgrimm jfgrimm added the change label Oct 11, 2022
@jfgrimm jfgrimm added this to the 4.x milestone Oct 11, 2022
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a ton of EasyConfigs, but I've scrolled through the changes and haven't spotted anything unintended. It's an approval from me, but since this affects so many EasyConfigs, I'll ask at least one other maintainer to also look at this :)

@boegel boegel changed the title update easyconfigs to use SYSTEM instead of True in dependencies update easyconfigs to use SYSTEM template instead of True in dependencies Oct 11, 2022
@boegel boegel changed the title update easyconfigs to use SYSTEM template instead of True in dependencies update easyconfigs to use SYSTEM template constant instead of True in dependencies Oct 11, 2022
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after visual review, test suite is happy, so no reason to hold this back...

Thanks for the effort on this @jfgrimm!

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 11, 2022

Test report by @boegel
SUCCESS
Build succeeded for 14 out of 14 (14 easyconfigs in total)
node3102.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/1574ae2ac46f61d56b40693c2b9761dd for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 11, 2022

Going in, thanks @jfgrimm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants