Skip to content

{devel}[GCC/11.2.0,GCC/11.3.0] Jansson v2.13 + v2.14#16053

Merged
boegel merged 6 commits intoeasybuilders:developfrom
sassy-crick:20220817152016_new_pr_Jansson214
Sep 5, 2022
Merged

{devel}[GCC/11.2.0,GCC/11.3.0] Jansson v2.13 + v2.14#16053
boegel merged 6 commits intoeasybuilders:developfrom
sassy-crick:20220817152016_new_pr_Jansson214

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Aug 17, 2022

(created using eb --new-pr)

@sassy-crick sassy-crick changed the title {devel}[GCC/11.2.0] Jansson v2.14 {devel}[GCC/11.2.0] Jansson v2.14 WIB Aug 17, 2022
@sassy-crick sassy-crick changed the title {devel}[GCC/11.2.0] Jansson v2.14 WIB {devel}[GCC/11.2.0] Jansson v2.14 Aug 17, 2022
@sassy-crick sassy-crick changed the title {devel}[GCC/11.2.0] Jansson v2.14 {devel}[GCC/11.2.0] Jansson v2.13/2.14 Aug 17, 2022
@anselmicz
Copy link
Copy Markdown
Contributor

anselmicz commented Aug 22, 2022

Test report by @anselmicz
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
login4.karolina.it4i.cz - Linux CentOS Linux 7 (Core), x86_64, AMD EPYC 7452 32-Core Processor, Python 3.10.4
See https://gist.github.com/018e4c22b5d1d99226d63362d68bb1b6 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 23, 2022

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/b1f03c2353f53e6802d5387f395d56c3 for a full test report.

verdurin
verdurin previously requested changes Aug 23, 2022
View reviewed changes
akesandgren
akesandgren previously requested changes Aug 29, 2022
View reviewed changes
easybuild/easyconfigs/j/Jansson/Jansson-2.13.1-GCC-11.2.0.eb Outdated
Comment on lines +24 to +29
# For configure, the ld.gold linker does not know anything about --default-symver and thus crashes
# So we simnply use the bfd linker
# preconfigopts = 'autoreconf -i && CC="$CC -fuse-ld=bfd" '
# This is not required with CMake

configopts = '-DJANSSON_BUILD_SHARED_LIBS=ON '
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move below builddeps

easybuild/easyconfigs/j/Jansson/Jansson-2.14-GCC-11.3.0.eb Outdated
Comment on lines +24 to +29
# For configure, the ld.gold linker does not know anything about --default-symver and thus crashes
# So we simnply use the bfd linker
# preconfigopts = 'autoreconf -i && CC="$CC -fuse-ld=bfd" '
# This is not required with CMake

configopts = '-DJANSSON_BUILD_SHARED_LIBS=ON '
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, below builddeps

@boegel boegel changed the title {devel}[GCC/11.2.0] Jansson v2.13/2.14 {devel}[GCC/11.2.0,GCC/11.3.0] Jansson v2.13 + v2.14 Sep 5, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 5, 2022

@boegelbot please test @ generoso

@boegel boegel dismissed stale reviews from akesandgren and verdurin September 5, 2022 19:03

configopts moved as requested

@boegel boegel added the update label Sep 5, 2022
@boegel boegel added this to the next release (4.6.1?) milestone Sep 5, 2022
boegel
boegel approved these changes Sep 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 5, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16053 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16053 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9111

Test results coming soon (I hope)...

Details

- notification for comment with ID 1237395696 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 5, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f16cef37f9e921dc8450d922dffcb230 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 5, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3151.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/f93b70c68dde4322533d72cbfce88a29 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 5, 2022

Going in, thanks @sassy-crick!

@boegel boegel merged commit c050a23 into easybuilders:develop Sep 5, 2022
@sassy-crick sassy-crick deleted the 20220817152016_new_pr_Jansson214 branch September 5, 2022 21:27
@sassy-crick sassy-crick mentioned this pull request Sep 21, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@verdurin verdurin verdurin left review comments

@akesandgren akesandgren akesandgren left review comments

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

4.6.1

Development

Successfully merging this pull request may close these issues.

6 participants

@sassy-crick @anselmicz @verdurin @boegel @boegelbot @akesandgren