{cae}[foss/2020b] OpenFOAM vv2112 by DirectorSloan · Pull Request #15731 · easybuilders/easybuild-easyconfigs

DirectorSloan · 2022-06-21T12:54:22Z

(created using eb --new-pr)

akesandgren · 2022-06-21T13:52:37Z

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb

+ to solid dynamics and electromagnetics."""
+
+toolchain = {'name': 'foss', 'version': '2020b'}
+toolchainopts = {'cstd': 'c++11'}


Need 'vectorize': False for correctness.

See OpenFOAM-v2112-foss-2021b.eb

I'm not sure this also applies when building OpenFOAM v2112 with foss/2020b, but it could.

See also #15495

So I've ~~take~~ took over all requested changes and re-requested review.

How should I proceed? Besides my orignally bad easyconfig structure I can at least report from user experiences that without the patches OpenFOAMv2112 foss2020b is usable at our cluster. I'll will now rebuild in staging with the patches.

It may be usable without the patches, but they are vital to get OpenFOAM to use the dependencies from EasyBuild and to build paraFoam correctly.

akesandgren · 2022-06-21T13:54:41Z

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb

+sources = [SOURCE_TGZ]
+checksums = [


Missing patches (see OpenFOAM-v2112-foss-2021b.eb)
patches = [
('OpenFOAM-v2012-cleanup.patch', 1),
'OpenFOAM-v1906-wmake-ompi.patch',
]

akesandgren · 2022-06-21T13:55:08Z

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb

+builddependencies = [
+    ('Bison', '3.7.1'),
+    ('CMake', '3.18.4'),
+    ('flex', '2.6.4'),
+]
+


Please move before dependencies

akesandgren · 2022-06-21T13:56:01Z

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb

+sanity_check_paths = {
+    'files': ['%(installdir)s/%(name)s-%(version)s/platforms/linux64GccDPInt32Opt/lib/dummy/libscotchDecomp.so'],
+    'dirs': ['%(installdir)s/%(name)s-%(version)s/platforms/linux64GccDPInt32Opt/lib/dummy'],
+}


Please remove, the openfoam easyblock handles this part.

akesandgren · 2022-06-28T05:35:13Z

@boegelbot Please test @ generoso

akesandgren · 2022-06-28T05:36:14Z

@boegelbot Please test @ jsc-zen2

boegelbot · 2022-06-28T05:37:07Z

@akesandgren: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15731 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15731 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 1350

Test results coming soon (I hope)...

Details

- notification for comment with ID 1168246919 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2022-06-28T09:12:48Z

Test report by @boegelbot
FAILED
Build succeeded for 21 out of 22 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/66783f09e953fbaffe1a24c9b3df8509 for a full test report.

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb

boegel · 2023-06-22T15:27:36Z

@boegelbot Please test @ jsc-zen2
CORE_CNT=16

boegelbot · 2023-06-22T15:32:08Z

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15731 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_15731 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 2853

Test results coming soon (I hope)...

Details

- notification for comment with ID 1602842826 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-06-22T16:43:29Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/dabf8e448f3f393b1c684b09b460d253 for a full test report.

boegel · 2023-06-22T17:01:42Z

@boegelbot Please test @ generoso
CORE_CNT=16

boegelbot · 2023-06-22T17:05:12Z

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15731 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_15731 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 11089

Test results coming soon (I hope)...

Details

- notification for comment with ID 1603017160 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-06-22T18:43:27Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a3a2fef6d0bc6defedcae2aaa3d60368 for a full test report.

boegel · 2023-06-22T20:44:14Z

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
node3120.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/6392c4363c4527c781ed80e78b653779 for a full test report.

missing patches added, other suggested changes also done

boegel · 2023-06-22T21:42:57Z

Going in, thanks @DirectorSloan!

adding easyconfigs: OpenFOAM-v2112-foss-2020b.eb

fb4eb74

akesandgren previously requested changes Jun 21, 2022

View reviewed changes

take over @akesandgren suggestions

2f87aa1

DirectorSloan requested a review from akesandgren June 24, 2022 07:41

boegel added this to the 4.x milestone Jun 24, 2022

boegel added the update label Jun 24, 2022

working sanity checks

5042cb3

boegel requested changes Jun 22, 2023

View reviewed changes

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2112-foss-2020b.eb Show resolved Hide resolved

retain useful comment regarding disabling 'vectorize' toolchain option

a894fd1

boegel approved these changes Jun 22, 2023

View reviewed changes

boegel merged commit 830072f into easybuilders:develop Jun 22, 2023

boegel modified the milestones: 4.x, next release (4.7.3?) Jun 22, 2023

		sources = [SOURCE_TGZ]
		checksums = [

Conversation

DirectorSloan commented Jun 21, 2022

Uh oh!

akesandgren Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

boegel Jun 24, 2022

Choose a reason for hiding this comment

Uh oh!

DirectorSloan Jun 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akesandgren Jun 28, 2022

Choose a reason for hiding this comment

Uh oh!

akesandgren Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

akesandgren Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

akesandgren Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

akesandgren commented Jun 28, 2022

Uh oh!

akesandgren commented Jun 28, 2022

Uh oh!

boegelbot commented Jun 28, 2022

Uh oh!

boegelbot commented Jun 28, 2022

Uh oh!

Uh oh!

boegel commented Jun 22, 2023

Uh oh!

boegelbot commented Jun 22, 2023

Uh oh!

boegelbot commented Jun 22, 2023

Uh oh!

boegel commented Jun 22, 2023

Uh oh!

boegelbot commented Jun 22, 2023

Uh oh!

boegelbot commented Jun 22, 2023

Uh oh!

boegel commented Jun 22, 2023

Uh oh!

boegel commented Jun 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DirectorSloan Jun 27, 2022 •

edited

Loading