Skip to content

add Bison and flex build dependencies to SCOTCH 6.1.x#15618

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20220605084534_new_pr_SCOTCH610
Jun 5, 2022
Merged

add Bison and flex build dependencies to SCOTCH 6.1.x#15618
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20220605084534_new_pr_SCOTCH610

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jun 5, 2022

(created using eb --new-pr)

Picked up from the failure in #15574 (comment)

(bison -pscotchyy -y -b y -d -v parser_yy.y &&      \
                 mv y.tab.c parser_yy.c &&      \
                 mv y.tab.h parser_ly.h) ||     \
                cp last_resort/parser_ly.h last_resort/parser_yy.c .

and

(flex -Pscotchyy -olex.yy.c parser_ll.l &&          \
                 mv lex.yy.c parser_ll.c) ||        \
                cp last_resort/parser_ll.c .

Though, this may not be needed in the older versions. The failure is

bison "-pscotchyy" --defines="parser_ly.h" --output="parser_yy.c" parser_yy.y
/bin/sh: bison: command not found

which seems to have lost the || cp ... part and that would explain why we've not seen this before now.

@boegel boegel added the bug fix label Jun 5, 2022
@boegel boegel added this to the 4.5.5 milestone Jun 5, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15618 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15618 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8657

Test results coming soon (I hope)...

Details

- notification for comment with ID 1146758611 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2022

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3108.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/d157c88867db4b99b034a207c4246745 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2022

Hmm, test on generoso completed, but test report failed to upload (due to HTTP Error 403: Forbidden), I'll assume that's a fluke...

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 5, 2022

Going in, thanks @branfosj!

@boegel boegel merged commit 02d2073 into easybuilders:develop Jun 5, 2022
@branfosj branfosj deleted the 20220605084534_new_pr_SCOTCH610 branch June 5, 2022 08:31
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 5, 2022

Test report by @Micket
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/8f208151623f4067a67a1c95992e5ddd for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants