don't disable optarch for Clang 11.0.0 by bartoldeman · Pull Request #11814 · easybuilders/easybuild-easyconfigs

bartoldeman · 2020-12-03T16:44:39Z

(created using eb --new-pr)

bartoldeman · 2020-12-03T17:20:02Z

@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2264"

bartoldeman · 2020-12-03T17:20:30Z

This needs easybuilders/easybuild-easyblocks#2264

boegelbot · 2020-12-03T17:25:27Z

@bartoldeman: Request for testing this PR well received on generoso

PR test command 'EB_PR=11814 EB_ARGS="--include-easyblocks-from-pr 2264" /apps/slurm/default/bin/sbatch --job-name test_PR_11814 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12188

Test results coming soon (I hope)...

Details

- notification for comment with ID 738154656 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Micket · 2020-12-03T18:43:53Z

@bartoldeman Any comment on the issue with optarch? Is the comment simply wrong?

bartoldeman · 2020-12-03T18:46:40Z

@bartoldeman Any comment on the issue with optarch? Is the comment simply wrong?

@Micket the comment is obsolete, it's copied from an earlier version but I had no issue building it with that line removed.
It dates back all the way to

Clang-3.4-GCC-4.8.2.eb:# Do not set optarch to True: it will cause the build to fail
Clang-3.4-GCC-4.8.2.eb:toolchainopts = {'optarch': False}

but has never been checked after I guess

bartoldeman · 2020-12-03T18:50:55Z

relevant commit for optarch:
fb453ae

Micket

lgtm (test build is going to take ages)

Micket · 2020-12-03T19:10:17Z

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2264
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/18c997407aa03ea758afdf3d2cc96b25 for a full test report.

Micket · 2020-12-03T19:19:03Z

I was wrong, it was very quick. Hmm

/local/EB/build/Clang/11.0.0/GCCcore-9.3.0/llvm-11.0.0.src/tools/lldb/bindings/./python/python-typemaps.swig:484: Error: Syntax error in input(3).

481 struct Py_buffer_RAII {
482   Py_buffer buffer = {};
483   Py_buffer_RAII() {};
484   Py_buffer &operator=(const Py_buffer_RAII &) = delete;
485   Py_buffer_RAII(const Py_buffer_RAII &) = delete;
486   ~Py_buffer_RAII() {
487     if (buffer.obj)
488       PyBuffer_Release(&buffer);
489   }
490 };

Looks fine to me, so I'm not sure what goes wrong here.

bartoldeman · 2020-12-03T19:46:02Z

@Micket perhaps it needs a build dep on swig, I my log I have:

-- Found SWIG: /cvmfs/soft.computecanada.ca/gentoo/2020/usr/bin/swig (found suitable version "3.0.12", minimum required is "2.0")

perhaps you picked up an OS SWIG that is now too old.

bartoldeman · 2020-12-03T19:52:00Z

I added the SWIG builddep because it's a good idea in any case.

Co-authored-by: Mikael Öhman <micketeer@gmail.com>

Micket

lgtm

boegelbot · 2020-12-03T21:34:12Z

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2264
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/42f09565d748a492bf1fa6feab2d8ad3 for a full test report.

bartoldeman · 2020-12-03T22:13:13Z

@boegelbot please test @ generoso EB_ARGS="--include-easyblocks-from-pr 2264"

bartoldeman · 2020-12-03T22:13:48Z

I asked the always friendly looking bot to do another build with the SWIG builddep

boegelbot · 2020-12-03T22:15:23Z

@bartoldeman: Request for testing this PR well received on generoso

PR test command 'EB_PR=11814 EB_ARGS="--include-easyblocks-from-pr 2264" /apps/slurm/default/bin/sbatch --job-name test_PR_11814 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12189

Test results coming soon (I hope)...

Details

- notification for comment with ID 738357106 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Micket · 2020-12-03T22:21:14Z

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2264
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.8.2003, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/189e66058b6e606f9ed00c1e03d44019 for a full test report.

Micket · 2020-12-03T23:42:12Z

@bartoldeman So.. Python turns out to be a runtime dependency;

$ lldb
lldb: error while loading shared libraries: libpython3.8.so.1.0: cannot open shared object file: No such file or directory

i was wrong

Micket · 2020-12-04T00:12:08Z

So, options as i see them

Just have python as a dependency here. Hurts a bit for a compiler though, since it means no multi-deps for anything using Clang.
Try to separate LLDB into a different module (probably painful) and let that module depend on Python.
Disable SWIG (we should probably enhance the easyblock to explicitly disable SWIG if no SWIG-dep is used regardless).

I assume python dep comes from SWIG? If not, then, well, option 3 just disappears.

bartoldeman · 2020-12-04T00:29:58Z

Maybe 2 (seperate lldb) is not too hard. Can give that a go.

boegelbot · 2020-12-04T02:25:42Z

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2264
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/34a31cb7764f5e67f2b9e3af4edf7238 for a full test report.

bartoldeman · 2020-12-04T13:51:01Z

#11822 does LLDB now. Though we can still remove the optarch line I guess.

verdurin · 2021-01-04T18:28:57Z

@bartoldeman what's the latest on this one?

bartoldeman · 2021-01-04T19:28:06Z

still the same, I forgot about this one :(. Will adjust

Only keep the optarch change

boegel · 2021-01-05T09:36:16Z

@boegelbot please test @ generoso

boegelbot · 2021-01-05T09:36:31Z

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11814 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11814 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12371

Test results coming soon (I hope)...

Details

- notification for comment with ID 754522127 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel · 2021-01-05T10:13:39Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/c0a3e5e706d079a452c1225eb533affe for a full test report.

boegel · 2021-01-05T12:01:28Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2641.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/24739a83ed6099ce78dc782377689c97 for a full test report.

verdurin · 2021-01-05T12:33:11Z

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
nuc.lan - Linux Fedora 32, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.8.6
See https://gist.github.com/b8f3779c8492b96e4ccd401cf7ab3f8f for a full test report.

verdurin

Looks fine.

boegelbot · 2021-01-05T13:11:17Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/9212af51c336674d445a260c1d98cdea for a full test report.

boegel · 2021-01-05T13:52:34Z

Going in, thanks @bartoldeman!

Clang: build lldb, don't disable optarch

ed95004

Micket added the enhancement label Dec 3, 2020

Micket previously approved these changes Dec 3, 2020

View reviewed changes

Clang: add SWIG builddep for lldb

ee8609c

bartoldeman dismissed Micket’s stale review via ee8609c December 3, 2020 19:49

Micket requested changes Dec 3, 2020

View reviewed changes

Comment thread easybuild/easyconfigs/c/Clang/Clang-11.0.0-GCCcore-9.3.0.eb Outdated

Clang-11.0.0: add comment about SWIG dep

0151972

Co-authored-by: Mikael Öhman <micketeer@gmail.com>

Micket previously approved these changes Dec 3, 2020

View reviewed changes

bartoldeman mentioned this pull request Dec 4, 2020

{debugger,lib}[GCCcore/9.3.0] LLDB v11.0.0, libedit v20191231 w/ Python 3.8 #11822

Merged

Update Clang-11.0.0-GCCcore-9.3.0.eb

53600aa

Only keep the optarch change

easybuilders deleted a comment from boegelbot Jan 5, 2021

boegel added this to the 4.x milestone Jan 5, 2021

boegel changed the title ~~Clang: build lldb, don't disable optarch~~ don't disable optarch for Clang 11.0.0 Jan 5, 2021

verdurin approved these changes Jan 5, 2021

View reviewed changes

boegel merged commit 2880377 into easybuilders:develop Jan 5, 2021

boegel modified the milestones: 4.x, next release (4.3.3?) Jan 5, 2021

Conversation

bartoldeman commented Dec 3, 2020

Uh oh!

bartoldeman commented Dec 3, 2020

Uh oh!

bartoldeman commented Dec 3, 2020

Uh oh!

boegelbot commented Dec 3, 2020

Uh oh!

Micket commented Dec 3, 2020

Uh oh!

bartoldeman commented Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bartoldeman commented Dec 3, 2020

Uh oh!

Micket left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Micket commented Dec 3, 2020

Uh oh!

Micket commented Dec 3, 2020

Uh oh!

bartoldeman commented Dec 3, 2020

Uh oh!

bartoldeman commented Dec 3, 2020

Uh oh!

Uh oh!

Micket left a comment

Choose a reason for hiding this comment

Uh oh!

boegelbot commented Dec 3, 2020

Uh oh!

bartoldeman commented Dec 3, 2020

Uh oh!

bartoldeman commented Dec 3, 2020

Uh oh!

boegelbot commented Dec 3, 2020

Uh oh!

Micket commented Dec 3, 2020

Uh oh!

Micket commented Dec 3, 2020

Uh oh!

Micket commented Dec 4, 2020

Uh oh!

bartoldeman commented Dec 4, 2020

Uh oh!

boegelbot commented Dec 4, 2020

Uh oh!

bartoldeman commented Dec 4, 2020 • edited by boegel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

verdurin commented Jan 4, 2021

Uh oh!

bartoldeman commented Jan 4, 2021

Uh oh!

boegel commented Jan 5, 2021

Uh oh!

boegelbot commented Jan 5, 2021

Uh oh!

boegel commented Jan 5, 2021

Uh oh!

boegel commented Jan 5, 2021

Uh oh!

verdurin commented Jan 5, 2021

Uh oh!

verdurin left a comment

Choose a reason for hiding this comment

Uh oh!

boegelbot commented Jan 5, 2021

Uh oh!

boegel commented Jan 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

bartoldeman commented Dec 3, 2020 •

edited

Loading

Micket left a comment •

edited

Loading

bartoldeman commented Dec 4, 2020 •

edited by boegel

Loading