Skip to content

honor (pre)configopts, (pre)buildopts and (pre)testopts in custom easyblock for HPCG#3986

Merged
boegel merged 4 commits intoeasybuilders:developfrom
Thyre:20251110180623_new_pr_hpcg
Nov 22, 2025
Merged

honor (pre)configopts, (pre)buildopts and (pre)testopts in custom easyblock for HPCG#3986
boegel merged 4 commits intoeasybuilders:developfrom
Thyre:20251110180623_new_pr_hpcg

Conversation

@Thyre
Copy link
Copy Markdown
Collaborator

@Thyre Thyre commented Nov 10, 2025

(created using eb --new-pr)

Also fixes a small issue where the cmd.sh wouldn't find the correct directory, therefore not placing a user in the build directory where the command was executed.

@Thyre Thyre added the bug fix label Nov 10, 2025
@boegel boegel added this to the next release (5.2.0) milestone Nov 19, 2025
@boegel boegel changed the title honor preconfigopts, buildopts and pretestopts in HPCG easyblock honor preconfigopts, buildopts and pretestopts in HPCG easyblock Nov 19, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 19, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="HPCG-3.1-foss-2025b.eb HPCG-3.1-intel-2025b.eb"

@boegelbot
Copy link
Copy Markdown

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3986 EB_ARGS="HPCG-3.1-foss-2025b.eb HPCG-3.1-intel-2025b.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3986 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8845

Test results coming soon (I hope)...

Details

- notification for comment with ID 3553358229 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS HPCG-3.1-foss-2025b.eb
  • SUCCESS HPCG-3.1-intel-2025b.eb

Build succeeded for 2 out of 2 (total: 1 min 27 secs) (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/0c9fb6194c683159a09b47e561222ca3 for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Nov 19, 2025

Tests with preconfigopts set can be found in easybuilders/easybuild-easyconfigs#24517

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided suggestions are "on sight", I didn't test those myself, but I hope it's clear that what's proposed is a lot more readable...

Thyre and others added 3 commits November 22, 2025 18:30
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Nov 22, 2025

Changes quickly tested in easybuilders/easybuild-easyconfigs#24517 (comment)

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Nov 22, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="HPCG-3.1-foss-2025b.eb HPCG-3.1-intel-2025b.eb"

@boegelbot
Copy link
Copy Markdown

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3986 EB_ARGS="HPCG-3.1-foss-2025b.eb HPCG-3.1-intel-2025b.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3986 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8887

Test results coming soon (I hope)...

Details

- notification for comment with ID 3566921146 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS HPCG-3.1-foss-2025b.eb
  • SUCCESS HPCG-3.1-intel-2025b.eb

Build succeeded for 2 out of 2 (total: 1 min 26 secs) (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/8a762637b032a5c9993ecb50b0b0ab34 for a full test report.

@boegel boegel changed the title honor preconfigopts, buildopts and pretestopts in HPCG easyblock honor (pre)configopts, (pre)buildopts and (pre)testopts in custom easyblock for HPCG Nov 22, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 22, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS HPCG-3.1-foss-2022b.eb
  • SUCCESS HPCG-3.1-foss-2023a.eb
  • SUCCESS HPCG-3.1-foss-2025b.eb
  • SUCCESS HPCG-3.1-intel-2023a.eb
  • SUCCESS HPCG-3.1-intel-2025b.eb

Build succeeded for 5 out of 5 (total: 1 min 51 secs) (5 easyconfigs in total)
node4224.shinx.os - Linux RHEL 9.6, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.21
See https://gist.github.com/boegel/5a2d922867275e574b6d5b369d564e3a for a full test report.

@boegel boegel merged commit 53c886d into easybuilders:develop Nov 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants