Revert resolve templates in CmdCp #3918 #3921
Open
Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Open
Revert resolve templates in CmdCp #3918 #3921Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Flamefire wants to merge 1 commit intoeasybuilders:developfrom
Conversation
Contributor
Author
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7429645, from #3918
Is equivalent to
for pattern, regex_cmd in self.cfg['cmds_map']:because the index-access resolves the template and does so recursively.Hence we can keep the simpler code.