Changes to LLVM easyblock required for LLVM 21 by Crivella · Pull Request #3902 · easybuilders/easybuild-easyblocks

Crivella · 2025-08-27T11:31:47Z

Changes

Filter unsupported flang args from FFLAGS and F90FLAGS as now flang is used to compile some .mod files
Fixes error of the type flang-21: error: unknown argument: '-fno-math-errno' during the build step
Added EC config parameter test_suite_include_benchmarks to allow including/excluding benchmarks in the test-suite
Ensure LLVM_INCLUDE_BENCHMARKS is set both for the projects and runtimes builds

bartoldeman

I also need this change:

--- llvm.py.1   2025-11-11 18:57:04.979489101 +0000
+++ llvm.py     2025-11-11 18:58:56.322052977 +0000
@@ -1103,7 +1103,7 @@
         opts = [f'--gcc-install-dir={self.gcc_prefix}']
 
         if self.dynamic_linker:
-            opts.append(f'-Wl,-dynamic-linker,{self.dynamic_linker}')
+            opts.append(f'-Wl,-dynamic-linker={self.dynamic_linker}')
             # The --dyld-prefix flag exists, but beside being poorly documented it is also not supported by flang
             # https://reviews.llvm.org/D851
             # prefix = self.sysroot.rstrip('/')

otherwise clang-nvlink-wrapper complains.

easybuild/easyblocks/l/llvm.py

…so with a bootstrap build and perform the filtering only if `flang` is being built

…hrough `test_suite_include_benchmarks` config parameter - If benchmarks are `OFF` ensure they are also not ran for the runtimes

…y of code

…INCLUDE_BENCHMARKS` together with `LLVM_INCLUDE_BENCHMARKS`

Crivella · 2026-01-07T16:30:36Z

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/ebpr-3902 LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0-minimal.eb LLVM-20.1.5-GCCcore-13.2.0.eb LLVM-20.1.8-GCCcore-14.3.0.eb"

boegelbot · 2026-01-07T16:33:09Z

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3902 EB_ARGS="--installpath /tmp/$USER/ebpr-3902 LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0-minimal.eb LLVM-20.1.5-GCCcore-13.2.0.eb LLVM-20.1.8-GCCcore-14.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3902 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 9346

Test results coming soon (I hope)...

Details

- notification for comment with ID 3719706977 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2026-01-07T22:42:27Z

Test report by @boegelbot

Overview of tested easyconfigs (in order)

SUCCESS LLVM-16.0.6-GCCcore-12.3.0.eb
SUCCESS LLVM-18.1.8-GCCcore-13.3.0-minimal.eb
SUCCESS LLVM-20.1.5-GCCcore-13.2.0.eb
SUCCESS LLVM-20.1.8-GCCcore-14.3.0.eb

Build succeeded for 4 out of 4 (total: 6 hours 8 mins 24 secs) (4 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/61beb4bd9b0fa8310b888ae91ce263d4 for a full test report.

easybuild/easyblocks/l/llvm.py

Thyre · 2026-01-19T16:52:01Z

easybuild/easyblocks/l/llvm.py

+        if self.version >= '21':
+            if self.version < '22':


What about LLVM 20?

LLVM 20 does not need knowledge of the flags here since it does not compile fortran stuff at build time (atleast not in a way that it uses our flags from EB causing failures)

easybuild/easyblocks/l/llvm.py

Thyre · 2026-01-19T16:53:24Z

Maybe also remove the WIP in the OP description, since we've resolved this now with the benchmark options 😄

Co-authored-by: Jan André Reuter <jan@zyten.de>

Thyre

LGTM.

boegel · 2026-01-20T17:50:51Z

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/ebpr-3902 LLVM-12.0.1-GCCcore-11.2.0.eb LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0-minimal.eb LLVM-18.1.8-GCCcore-13.3.0.eb LLVM-19.1.7-GCCcore-13.3.0.eb LLVM-20.1.8-GCCcore-14.3.0.eb"

boegel

lgtm

boegelbot · 2026-01-20T17:53:09Z

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3902 EB_ARGS="--installpath /tmp/$USER/ebpr-3902 LLVM-12.0.1-GCCcore-11.2.0.eb LLVM-16.0.6-GCCcore-12.3.0.eb LLVM-18.1.8-GCCcore-13.3.0-minimal.eb LLVM-18.1.8-GCCcore-13.3.0.eb LLVM-19.1.7-GCCcore-13.3.0.eb LLVM-20.1.8-GCCcore-14.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3902 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 9446

Test results coming soon (I hope)...

Details

- notification for comment with ID 3774188847 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2026-01-21T01:42:58Z

Test report by @boegelbot

Overview of tested easyconfigs (in order)

SUCCESS LLVM-12.0.1-GCCcore-11.2.0.eb
SUCCESS LLVM-16.0.6-GCCcore-12.3.0.eb
SUCCESS LLVM-18.1.8-GCCcore-13.3.0-minimal.eb
SUCCESS LLVM-18.1.8-GCCcore-13.3.0.eb
SUCCESS LLVM-19.1.7-GCCcore-13.3.0.eb
SUCCESS LLVM-20.1.8-GCCcore-14.3.0.eb

Build succeeded for 6 out of 6 (total: 7 hours 49 mins 5 secs) (6 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.23
See https://gist.github.com/boegelbot/87e4cfa816e1848b69997f0488398fab for a full test report.

requested changes made

Crivella mentioned this pull request Aug 27, 2025

{compiler}[GCCcore/14.3.0] LLVM 21.1.2 easybuilders/easybuild-easyconfigs#23750

Closed

boegel added the update label Aug 27, 2025

boegel added this to the release after 5.1.2 (5.2.0?) milestone Aug 27, 2025

Crivella force-pushed the feature-LLVM_21 branch from 910d7fd to d0d7590 Compare August 28, 2025 13:55

Crivella force-pushed the feature-LLVM_21 branch from d0d7590 to e36597d Compare September 10, 2025 07:53

bartoldeman previously requested changes Nov 11, 2025

View reviewed changes

bartoldeman added a commit to ComputeCanada/easybuild-easyblocks that referenced this pull request Nov 12, 2025

Add LLVM easyblock with upstream PR easybuilders#3902 changes

e3a7765

boegel modified the milestones: next release (5.2.0), release after 5.2.0 Dec 14, 2025

Thyre mentioned this pull request Jan 5, 2026

{tools}[GCCcore/15.2.0] lit v18.1.8, LLVM v21.1.8, psutil v7.2.1, Z3 v4.15.4 easybuilders/easybuild-easyconfigs#25009

Merged

5 tasks

Thyre reviewed Jan 6, 2026

View reviewed changes

easybuild/easyblocks/l/llvm.py Outdated Show resolved Hide resolved

Crivella added 6 commits January 7, 2026 10:16

Filter flang args

6c88499

Moved flag filtering to configure_final_build to ensure it works al…

e4057f7

…so with a bootstrap build and perform the filtering only if `flang` is being built

Fixed sanity checks

ac350e5

Allow EB to work with --module-only

17e874e

- Allow EC to specify if benchmarks should be ran in the test-suite t…

54a2f60

…hrough `test_suite_include_benchmarks` config parameter - If benchmarks are `OFF` ensure they are also not ran for the runtimes

vectorize flags are now supported, also improved logic and reusabilit…

6609eb3

…y of code

Crivella force-pushed the feature-LLVM_21 branch from e36597d to 6609eb3 Compare January 7, 2026 09:18

Also explicitly enable/disable LIBCXX_INCLUDE_BENCHMARKS and `LIBC_…

86d902b

…INCLUDE_BENCHMARKS` together with `LLVM_INCLUDE_BENCHMARKS`

Crivella marked this pull request as ready for review January 7, 2026 13:26

Use = instead of , for the ddynamic linker selection

f94de3a

Thyre suggested changes Jan 19, 2026

View reviewed changes

Crivella and others added 4 commits January 19, 2026 18:01

Update easybuild/easyblocks/l/llvm.py

0d4a640

Co-authored-by: Jan André Reuter <jan@zyten.de>

Update easybuild/easyblocks/l/llvm.py

db8b69f

Co-authored-by: Jan André Reuter <jan@zyten.de>

Update easybuild/easyblocks/l/llvm.py

533d078

Co-authored-by: Jan André Reuter <jan@zyten.de>

Update easybuild/easyblocks/l/llvm.py

0ee2e9c

Co-authored-by: Jan André Reuter <jan@zyten.de>

Update easybuild/easyblocks/l/llvm.py

d23b103

Co-authored-by: Jan André Reuter <jan@zyten.de>

Thyre approved these changes Jan 19, 2026

View reviewed changes

boegel approved these changes Jan 20, 2026

View reviewed changes

boegel merged commit 3721d45 into easybuilders:develop Jan 28, 2026
22 checks passed

Crivella deleted the feature-LLVM_21 branch January 28, 2026 08:44

Conversation

Crivella commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

bartoldeman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Crivella commented Jan 7, 2026

Uh oh!

boegelbot commented Jan 7, 2026

Uh oh!

boegelbot commented Jan 7, 2026

Overview of tested easyconfigs (in order)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Thyre Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Crivella Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Thyre commented Jan 19, 2026

Uh oh!

Thyre left a comment

Choose a reason for hiding this comment

Uh oh!

boegel commented Jan 20, 2026

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegelbot commented Jan 20, 2026

Uh oh!

boegelbot commented Jan 21, 2026

Overview of tested easyconfigs (in order)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Crivella commented Aug 27, 2025 •

edited

Loading