Skip to content

enhance custom easyblock for LLVM to run tests in parallel #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 2 commits into from
Aug 12, 2025
Merged

enhance custom easyblock for LLVM to run tests in parallel #3875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b9694
Run LLVM tests in parallel
Flamefire Aug 8, 2025
597f837
Do not restrict to LLVM 14+
Flamefire Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion easybuild/easyblocks/l/llvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,19 @@ def configure_step(self):
regex_subs.append((r'add_subdirectory\(bindings/python/tests\)', ''))
apply_regex_substitutions(cmakelists_tests, regex_subs)

# Avoid concurrency issue in tests, see https://github.com/llvm/llvm-project/pull/151313
llvm_version = LooseVersion(self.version)
if llvm_version < '20.1':
regex_subs = [(r'cmake_policy\(SET CMP0114 OLD\)', 'cmake_policy(SET CMP0114 NEW)')]
tgt_file = os.path.join('llvm', 'CMakeLists.txt')
if llvm_version >= '16':
# 16.x moved the policy settings to a new file
tgt_file = os.path.join('cmake', 'Modules', 'CMakePolicy.cmake')
elif llvm_version < '15':
# Earlier versions didn't set this policy -> add line
regex_subs = [(r'(project\(LLVM)', r'if(POLICY CMP0114)\n cmake_policy(SET CMP0114 NEW)\nendif()\n\1')]
apply_regex_substitutions(tgt_file, regex_subs, on_missing_match=ERROR)

# Remove flags disabling the use of configuration files during compiler-rt tests as we in general rely on them
# (see https://github.com/easybuilders/easybuild-easyblocks/pull/3741#issuecomment-2939404304)
lit_cfg_file = os.path.join(self.start_dir, 'compiler-rt', 'test', 'lit.common.cfg.py')
Expand Down Expand Up @@ -1342,7 +1355,11 @@ def test_step(self):
self.log.warning("ROCr-Runtime not in dependencies, ignoring failing tests for AMDGPU target.")

max_failed = self.cfg['test_suite_max_failed']
num_failed = self._para_test_step(parallel=1)
if LooseVersion(get_software_version("CMake")) >= '3.19':
parallel = self.cfg.parallel
else:
parallel = 1
num_failed = self._para_test_step(parallel=parallel)
if num_failed is None:
self.report_test_failure("Failed to extract test results from output")
return
Expand Down