Skip to content

clean up GCC-related options for full-LLVM build#3827

Merged
Crivella merged 2 commits intoeasybuilders:developfrom
Flamefire:llvm-cleanup
Jul 9, 2025
Merged

clean up GCC-related options for full-LLVM build#3827
Crivella merged 2 commits intoeasybuilders:developfrom
Flamefire:llvm-cleanup

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jul 4, 2025

This is purely a refactoring without any behavior change

  • Add comment what the option dict is used for: Only for dependency-less (builds when full_llvm=True)
  • Remove condition on full_llvm when setting such options.
  • Remove some commented code. The comments on where they have been moved to are better suited for the commit / PR description, aren't they?

Closes #3826

- Add comment what the option dict is used for: Only for dependency-less (builds when `full_llvm=True`)
- Remove condition on `full_llvm` when setting such options.
- Remove some commented code
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 3 (3 easyconfigs in total)
n1079 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (sapphirerapids), Python 3.9.18
See https://gist.github.com/Flamefire/a897319fccf89961cdea6b7d64d0b40d for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-19.1.7-GCCcore-13.3.0.eb
  • SUCCESS LLVM-20.1.5-GCCcore-13.3.0.eb
  • SUCCESS LLVM-18.1.8-GCCcore-13.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
c83 - Linux AlmaLinux 9.4, x86_64, AMD EPYC 9334 32-Core Processor (zen4), 4 x NVIDIA NVIDIA H100, 560.35.03, Python 3.9.18
See https://gist.github.com/Flamefire/da7014d708d8f52d333f74ab4d32c14b for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-19.1.7-GCCcore-13.3.0.eb
  • SUCCESS LLVM-20.1.5-GCCcore-13.3.0.eb
  • SUCCESS LLVM-18.1.8-GCCcore-13.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
i7184 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/Flamefire/f138c1d21a86e25fbe301f1191b229c3 for a full test report.

@Crivella
Copy link
Contributor

Crivella commented Jul 8, 2025

Got conflicts after merging #3825

@Flamefire
Copy link
Contributor Author

Resolved with merge

@Crivella
Copy link
Contributor

Crivella commented Jul 8, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="LLVM-18.1.8-GCCcore-13.3.0.eb LLVM-19.1.7-GCCcore-13.3.0.eb LLVM-20.1.5-GCCcore-13.3.0.eb"
CORE_CNT=16

@boegelbot
Copy link

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3827 EB_ARGS="LLVM-18.1.8-GCCcore-13.3.0.eb LLVM-19.1.7-GCCcore-13.3.0.eb LLVM-20.1.5-GCCcore-13.3.0.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3827 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7166

Test results coming soon (I hope)...

Details

- notification for comment with ID 3047843586 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 3 (3 easyconfigs in total)
n1577 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (sapphirerapids), Python 3.9.18
See https://gist.github.com/Flamefire/0d95815dee21b1dd377abccde4358824 for a full test report.

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS LLVM-18.1.8-GCCcore-13.3.0.eb
  • SUCCESS LLVM-19.1.7-GCCcore-13.3.0.eb
  • SUCCESS LLVM-20.1.5-GCCcore-13.3.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/c8d64d397db1a8ebc8d6fbd3cc621ef4 for a full test report.

Copy link
Contributor

@Crivella Crivella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Crivella Crivella added this to the release after 5.1.1 milestone Jul 9, 2025
@Crivella
Copy link
Contributor

Crivella commented Jul 9, 2025

Going in, thanks @Flamefire!

@Crivella Crivella merged commit f04a995 into easybuilders:develop Jul 9, 2025
17 checks passed
@Flamefire Flamefire deleted the llvm-cleanup branch July 9, 2025 08:21
@boegel boegel changed the title Cleanup GCC-related options for full-LLVM build clean up GCC-related options for full-LLVM build Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow libatomic in LLVM builds

4 participants