Skip to content

Don't install libomp aliases by default in LLVM easyblock #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crivella merged 5 commits into from
Jul 8, 2025
Merged

Don't install libomp aliases by default in LLVM easyblock #3825

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ecad4f2
Don't install libomp aliases by default in LLVM easyblock
Flamefire Jul 4, 2025
e0b0c52
Downgrade a warning to a debug log
Flamefire Jul 4, 2025
7df0f81
Combine checks for options dependent on OpenMP and add one for the al…
Flamefire Jul 4, 2025
7dfb73d
Consistently uses OFF/ON for CMake options
Flamefire Jul 4, 2025
147962d
Merge branch 'easybuilders:develop' into openmp-symlink-option
Flamefire Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 44 additions & 34 deletions easybuild/easyblocks/l/llvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,44 +88,44 @@
# 'CLANG_DEFAULT_LINKER': 'lld',
'CLANG_DEFAULT_UNWINDLIB': 'libunwind',

'COMPILER_RT_BUILD_GWP_ASAN': 'Off',
'COMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER': 'On',
'COMPILER_RT_ENABLE_STATIC_UNWINDER': 'On', # https://lists.llvm.org/pipermail/llvm-bugs/2016-July/048424.html
'COMPILER_RT_USE_BUILTINS_LIBRARY': 'On',
'COMPILER_RT_USE_LIBCXX': 'On',
'COMPILER_RT_USE_LLVM_UNWINDER': 'On',
'COMPILER_RT_BUILD_GWP_ASAN': 'OFF',
'COMPILER_RT_ENABLE_INTERNAL_SYMBOLIZER': 'ON',
'COMPILER_RT_ENABLE_STATIC_UNWINDER': 'ON', # https://lists.llvm.org/pipermail/llvm-bugs/2016-July/048424.html
'COMPILER_RT_USE_BUILTINS_LIBRARY': 'ON',
'COMPILER_RT_USE_LIBCXX': 'ON',
'COMPILER_RT_USE_LLVM_UNWINDER': 'ON',

'LIBCXX_CXX_ABI': 'libcxxabi',
'LIBCXX_DEFAULT_ABI_LIBRARY': 'libcxxabi',
# Needed as libatomic could not be present on the system (compilation and tests will succeed because of the
# GCCcore builddep, but usage/sanity check will fail due to missing libatomic)
'LIBCXX_HAS_ATOMIC_LIB': 'NO',
'LIBCXX_HAS_GCC_S_LIB': 'Off',
'LIBCXX_USE_COMPILER_RT': 'On',
'LIBCXX_HAS_ATOMIC_LIB': 'OFF',
'LIBCXX_HAS_GCC_S_LIB': 'OFF',
'LIBCXX_USE_COMPILER_RT': 'ON',

'LIBCXXABI_HAS_GCC_S_LIB': 'Off',
'LIBCXXABI_USE_LLVM_UNWINDER': 'On',
'LIBCXXABI_USE_COMPILER_RT': 'On',
'LIBCXXABI_HAS_GCC_S_LIB': 'OFF',
'LIBCXXABI_USE_LLVM_UNWINDER': 'ON',
'LIBCXXABI_USE_COMPILER_RT': 'ON',

'LIBUNWIND_HAS_GCC_S_LIB': 'Off',
'LIBUNWIND_USE_COMPILER_RT': 'On',
'LIBUNWIND_HAS_GCC_S_LIB': 'OFF',
'LIBUNWIND_USE_COMPILER_RT': 'ON',

# Libxml2 from system gets automatically detected and linked in bringing dependencies from stdc++, gcc_s, icuuc, etc
# Moved to a check at the configure step. See https://github.com/easybuilders/easybuild-easyconfigs/issues/22491
# 'LLVM_ENABLE_LIBXML2': 'Off',
# 'LLVM_ENABLE_LIBXML2': 'OFF',

'SANITIZER_USE_STATIC_LLVM_UNWINDER': 'On',
'SANITIZER_USE_STATIC_LLVM_UNWINDER': 'ON',
}

DISABLE_WERROR_OPTS = {
'BENCHMARK_ENABLE_WERROR': 'Off',
'COMPILER_RT_ENABLE_WERROR': 'Off',
'FLANG_ENABLE_WERROR': 'Off',
'LIBC_WNO_ERROR': 'On',
'LIBCXX_ENABLE_WERROR': 'Off',
'LIBUNWIND_ENABLE_WERROR': 'Off',
'LLVM_ENABLE_WERROR': 'Off',
'OPENMP_ENABLE_WERROR': 'Off',
'BENCHMARK_ENABLE_WERROR': 'OFF',
'COMPILER_RT_ENABLE_WERROR': 'OFF',
'FLANG_ENABLE_WERROR': 'OFF',
'LIBC_WNO_ERROR': 'ON',
'LIBCXX_ENABLE_WERROR': 'OFF',
'LIBUNWIND_ENABLE_WERROR': 'OFF',
'LLVM_ENABLE_WERROR': 'OFF',
'OPENMP_ENABLE_WERROR': 'OFF',
}

GENERAL_OPTS = {
Expand Down Expand Up @@ -212,6 +212,7 @@ def extra_options():
'build_lld': [False, "Build the LLVM lld linker", CUSTOM],
'build_lldb': [False, "Build the LLVM lldb debugger", CUSTOM],
'build_openmp': [True, "Build the LLVM OpenMP runtime", CUSTOM],
'build_openmp_library_aliases': [False, "Install symlinks to libomp (e.g. libgomp, libiomp5)", CUSTOM],
'build_openmp_offload': [True, "Build the LLVM OpenMP offload runtime", CUSTOM],
'build_openmp_tools': [True, "Build the LLVM OpenMP tools interface", CUSTOM],
'build_runtimes': [False, "Build the LLVM runtimes (compiler-rt, libunwind, libcxx, libcxxabi)", CUSTOM],
Expand Down Expand Up @@ -327,20 +328,29 @@ def __init__(self, *args, **kwargs):

if self.cfg['build_openmp']:
self.final_projects.append('openmp')
else:
errors = []
# check for all options that depend on OpenMP being enabled
if self.cfg['build_openmp_tools']:
errors.append("Building OpenMP tools requires building OpenMP runtime")

if self.cfg['build_openmp_offload']:
errors.append("Building OpenMP offload requires building OpenMP runtime")

if self.cfg['build_openmp_library_aliases']:
errors.append("Installing OpenMP library aliases requires building OpenMP runtime")

if errors:
raise EasyBuildError('\n'.join(errors), exit_code=EasyBuildExit.EASYCONFIG_ERROR)

if self.cfg['build_openmp_offload']:
if not self.cfg['build_openmp']:
raise EasyBuildError("Building OpenMP offload requires building OpenMP runtime")
# LLVM 19 added a new runtime target for explicit offloading
# https://discourse.llvm.org/t/llvm-19-1-0-no-library-libomptarget-nvptx-sm-80-bc-found/81343
if LooseVersion(self.version) >= '19':
self.log.debug("Explicitly enabling OpenMP offloading for LLVM >= 19")
self.final_runtimes.append('offload')
else:
self.log.warning("OpenMP offloading is included with the OpenMP runtime for LLVM < 19")

if self.cfg['build_openmp_tools'] and not self.cfg['build_openmp']:
raise EasyBuildError("Building OpenMP tools requires building OpenMP runtime")
self.log.debug("OpenMP offloading is included with the OpenMP runtime for LLVM < 19")

if self.cfg['use_polly']:
self.final_projects.append('polly')
Expand All @@ -359,9 +369,9 @@ def __init__(self, *args, **kwargs):
if self.cfg['build_lldb']:
self.final_projects.append('lldb')
if self.full_llvm:
self.remove_gcc_dependency_opts['LLDB_ENABLE_LIBXML2'] = 'Off'
self.remove_gcc_dependency_opts['LLDB_ENABLE_LZMA'] = 'Off'
self.remove_gcc_dependency_opts['LLDB_ENABLE_PYTHON'] = 'Off'
self.remove_gcc_dependency_opts['LLDB_ENABLE_LIBXML2'] = 'OFF'
self.remove_gcc_dependency_opts['LLDB_ENABLE_LZMA'] = 'OFF'
self.remove_gcc_dependency_opts['LLDB_ENABLE_PYTHON'] = 'OFF'

if self.cfg['build_bolt']:
self.final_projects.append('bolt')
Expand Down Expand Up @@ -528,7 +538,7 @@ def _configure_final_build(self):
if self.nvptx_target_cond:
self._cmakeopts['LIBOMPTARGET_FORCE_DLOPEN_LIBCUDA'] = 'ON'
self._cmakeopts['OPENMP_ENABLE_LIBOMPTARGET'] = 'ON'
self._cmakeopts['LIBOMP_INSTALL_ALIASES'] = 'ON'
self._cmakeopts['LIBOMP_INSTALL_ALIASES'] = 'ON' if self.cfg['build_openmp_library_aliases'] else 'OFF'
if not self.cfg['build_openmp_tools']:
self._cmakeopts['OPENMP_ENABLE_OMPT_TOOLS'] = 'OFF'

Expand Down