Alternative refactoring and fix for LLVM easyblock#3818
Closed
Flamefire wants to merge 13 commits intoeasybuilders:developfrom
Closed
Alternative refactoring and fix for LLVM easyblock#3818Flamefire wants to merge 13 commits intoeasybuilders:developfrom
Flamefire wants to merge 13 commits intoeasybuilders:developfrom
Conversation
- Use f-Strings - Update comments - Use list append/extend
`LooseVersion(self.version)` in `sanity_check_step` can be done only once. Comparisons of a LooseVersion to a string already converts the string.
This was done by previous versions of the easyblock and not using the default for LLVM 18 (which is "all", i.e. all supported CUDA CCs) might break tests.
Contributor
Author
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 3 (3 easyconfigs in total) |
Contributor
Author
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 3 (3 easyconfigs in total) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #3755 but reintroducing the restriction to LLVM < 18 to not set
LIBOMPTARGET_DEVICE_ARCHITECTURESThis might have been the cause of test failures.