Skip to content

handle $PATH environment variable with module_load_environment in init of Binary easyblock#3787

Merged
ocaisa merged 2 commits intoeasybuilders:developfrom
lexming:binary-modenv
Jun 20, 2025
Merged

handle $PATH environment variable with module_load_environment in init of Binary easyblock#3787
ocaisa merged 2 commits intoeasybuilders:developfrom
lexming:binary-modenv

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Jun 18, 2025

This went through the cracks with the introduction of module_load_environment in EB5

@ocaisa
Copy link
Member

ocaisa commented Jun 18, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="Baysor-0.7.1.eb --installpath /tmp/$USER/ebpr-3787"

@boegelbot
Copy link

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3787 EB_ARGS="Baysor-0.7.1.eb --installpath /tmp/$USER/ebpr-3787" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3787 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6876

Test results coming soon (I hope)...

Details

- notification for comment with ID 2983049216 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/c68f795959dd1f5f67937d10759d6355 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Jun 18, 2025

@lexming For the only existing case I could find, this doesn't seem to be working: https://gist.github.com/boegelbot/dd5a43beb6d1b9dfe15ecd636aa22d83#file-baysor-0-7-1_partial-log-L327

@lexming
Copy link
Contributor Author

lexming commented Jun 19, 2025

@ocaisa I made a stupid mistake, it was not properly handling the list in that option. Fixed in f81244c

@lexming
Copy link
Contributor Author

lexming commented Jun 19, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="Baysor-0.7.1.eb --installpath /tmp/$USER/ebpr-3787"

@boegelbot
Copy link

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3787 EB_ARGS="Baysor-0.7.1.eb --installpath /tmp/$USER/ebpr-3787" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3787 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6913

Test results coming soon (I hope)...

Details

- notification for comment with ID 2988693803 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS Baysor-0.7.1.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/be44a4d214255d6ee0dae219a7196e68 for a full test report.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Member

ocaisa commented Jun 20, 2025

@ocaisa I made a stupid mistake, it was not properly handling the list in that option. Fixed in f81244c

Not allowed say that, mistakes are never stupid when the intention is good, no shame in them!

@ocaisa ocaisa merged commit bd2091d into easybuilders:develop Jun 20, 2025
17 checks passed
@lexming lexming deleted the binary-modenv branch June 20, 2025 12:49
@boegel boegel added this to the 5.1.1 milestone Jul 2, 2025
@boegel boegel changed the title handle PATH environment variable with module_load_environment in init of Binary easyblock handle $PATH environment variable with module_load_environment in init of Binary easyblock Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants