only run pip check once for Python installation + move det_installed_python_packages, det_pip_version, run_pip_check to Python easyblock#3730
Merged
lexming merged 2 commits intoeasybuilders:developfrom May 23, 2025
Conversation
…ck` to Python easyblock, so they can also be used there
Member
Author
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Contributor
|
Merging, thanks @boegel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up for #3432
The changes there don't apply to
Pythonitself, since that doesn't usePythonBundleat all (which we can't do, because we import stuff frompythonpackagein there, which in turn imports stuff from the Python easyblock).The
det_installed_python_packages,det_pip_version, andrun_pip_checkfunction were moved (without any changes) to the Python easyblock, otherwise we can't userun_pip_check(since we can't import it fromPythonPackageeasyblock without introducing a cyclic import).No changes are needed for easyblock that import for example
det_pip_version(which was introduced a long time ago, in EasyBuild v4.1.0) fromeasybuild.easyblocks.generic.pythonpackage, that'll still work fine.