Skip to content

Fix missed f-string in pythonpackage #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfgrimm merged 2 commits into from
May 27, 2025
Merged

Fix missed f-string in pythonpackage #3729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
613753d
Fix missed f-string in pythonpackage
Flamefire May 23, 2025
4b4fbfe
Remove reindroduced super args
Flamefire May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion easybuild/easyblocks/generic/pythonbundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def sanity_check_step(self, *args, **kwargs):

def _sanity_check_step_extensions(self):
"""Run the pip check for extensions if enabled"""
super(PythonBundle, self)._sanity_check_step_extensions()
super()._sanity_check_step_extensions()

sanity_pip_check = self.cfg['sanity_pip_check']
unversioned_packages = set(self.cfg['unversioned_packages'])
Expand Down
6 changes: 3 additions & 3 deletions easybuild/easyblocks/generic/pythonpackage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,9 +1046,9 @@ def sanity_check_step(self, *args, **kwargs):
# If the main easyblock (e.g. PythonBundle) defines the variable
# we trust it does the pip check if requested and checks for mismatches
sanity_pip_check = False
msg = "Sanity 'pip check' disabled for {self.name} extension, "
msg += "assuming that parent will take care of it"
self.log.info(msg)
self.log.info(f"Sanity 'pip check' disabled for {self.name} extension, "
f"assuming that parent will take care of it"
)

if sanity_pip_check:
if not self.is_extension:
Expand Down