sync with develop (20250313)#3662
Merged
branfosj merged 29 commits intoeasybuilders:5.0.xfrom Mar 13, 2025
Merged
Conversation
AOCC 4.2.0 and lower (and 'flang' for AOCC 5.0.0) use compiler wrappers to include the GCC toolchain in the compiler command. The original compilers are renamed, and a shell script is created running 'exec' which passes the original compiler name as an argument. This however can fail if '/bin/sh' is used. On Ubuntu 22.04 LTS, using 'exec -a' causes the following error message, which then causes the sanity check to fail: ``` $ exec -a "echo" echo "Hello World" sh: 1: exec: -a: not found ``` To work around this, use '/bin/bash' instead. Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
…w_pr_pytorch Use unittest XML files to parse PyTorch test results
…ckwards compatibility
… definition in easyconfig
…pper AOCC: Use bash for compiler wrapper
…w_pr_cargo Fix cargo build when git branch is referenced
branfosj
approved these changes
Mar 13, 2025
boegel
reviewed
Mar 13, 2025
|
|
||
| self.has_xml_test_reports = False | ||
| if pytorch_version >= '1.10.0': | ||
| out, ec = run_shell_cmd(self.python_cmd + " -c 'import xmlrunner'") |
Member
There was a problem hiding this comment.
This wasn't correctly ported to run_shell_cmd, fixing that in #3664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.