make AOCC compiler wrappers aware of keepsymlinks option#3659
make AOCC compiler wrappers aware of keepsymlinks option#3659branfosj merged 4 commits intoeasybuilders:5.0.xfrom
Conversation
|
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 2 (2 easyconfigs in total) Ah.. fixed with #3648. I need to test this with another machine... |
AOCC 4.2.0 and lower (and 'flang' for AOCC 5.0.0) use compiler wrappers to include the GCC toolchain in the compiler command. The original compilers are renamed, and a shell script is created running 'exec' which passes the original compiler name as an argument. This however can fail if '/bin/sh' is used. On Ubuntu 22.04 LTS, using 'exec -a' causes the following error message, which then causes the sanity check to fail: ``` $ exec -a "echo" echo "Hello World" sh: 1: exec: -a: not found ``` To work around this, use '/bin/bash' instead. Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
|
@Thyre thanks for the tests! updated with your fix to the wrapper |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Thanks a lot! Tests look fine on my machines as far as I can tell. |
AOCC easyblock is broken since the recent change enabling
keepsymlinksby default. More information: easybuilders/easybuild-framework#4794This PR makes AOCC aware of
keepsymlinks. Wrappers will only be made for real executables and the wrapper is updated to forward whatever command is used to execute the compiler (i.e. the wrapper forwards$0).