Skip to content

Conversation

@appolloford
Copy link
Contributor

(created using eb --new-pr)

@Micket
Copy link
Contributor

Micket commented Mar 6, 2025

The module only needs to be able to work without an actual installation. A bit silly requirement but this can't be merged as this is. We'll have to skip those parts if necessary

@boegel boegel added the update label Mar 19, 2025
@boegel boegel added this to the 5.x milestone Mar 19, 2025
@boegel
Copy link
Member

boegel commented Mar 19, 2025

@appolloford I changed to target branch in this PR from 5.0.x to develop, you should synchronize your PR branch with current develop branch (which has received a massive update after the release of EasyBuild v5.0.0, see #3670)

@boegel boegel changed the base branch from 5.0.x to develop March 19, 2025 11:10
@appolloford
Copy link
Contributor Author

I don't think anything in this PR is affected by the synchronization.

@boegel boegel modified the milestones: 5.x.x, 5.x Apr 9, 2025
@Micket Micket closed this Apr 15, 2025
@Micket Micket reopened this Apr 15, 2025
@Micket
Copy link
Contributor

Micket commented Apr 15, 2025

At minimum, we need to retrigger test, never know what might change and we don't wanna risk breaking develop's CI from an outdated PR CI

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 2c9168d into easybuilders:develop Apr 15, 2025
33 checks passed
@boegel boegel modified the milestones: 5.x, release after 5.0.0 Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants