Skip to content

allow installing from commit for LAMMPS#3582

Merged
laraPPr merged 2 commits intoeasybuilders:developfrom
smoors:20250207093025_new_pr_lammps
Feb 11, 2025
Merged

allow installing from commit for LAMMPS#3582
laraPPr merged 2 commits intoeasybuilders:developfrom
smoors:20250207093025_new_pr_lammps

Conversation

@smoors
Copy link
Contributor

@smoors smoors commented Feb 7, 2025

(created using eb --new-pr)

@boegel
Copy link
Member

boegel commented Feb 7, 2025

@smoors I don't think this is sufficient, see also @laraPPr's PR:

@smoors
Copy link
Contributor Author

smoors commented Feb 7, 2025

@smoors I don't think this is sufficient, see also @laraPPr's PR:

* [LAMMPS: generate version from the source files when using `software-commit` #3485](https://github.com/easybuilders/easybuild-easyblocks/pull/3485)

can you explain why not?
it works perfectly for easybuilders/easybuild-easyconfigs#22268
i just tested and --module-only also works.

@laraPPr
Copy link
Contributor

laraPPr commented Feb 7, 2025

Ah that does something else. In my case we don't put a valid date in version. So than we need all that stuff that is in the other pr. So mine should include what you need and than a whole lot of other stuff. Can you test my easyBlock with your easyconfig?

@laraPPr laraPPr merged commit d0c5506 into easybuilders:develop Feb 11, 2025
41 checks passed
@branfosj branfosj added this to the release after 4.9.4 milestone Mar 2, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants