Skip to content

take into account that f90wrap_version may be None in MetalWalls easyblock#3468

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Crivella:feature-MWfix
Jul 2, 2025
Merged

take into account that f90wrap_version may be None in MetalWalls easyblock#3468
boegel merged 1 commit intoeasybuilders:developfrom
Crivella:feature-MWfix

Conversation

@Crivella
Copy link
Contributor

@Crivella Crivella commented Oct 3, 2024

Fix exception caused by calling LoosVersion on f90wrap_version even when it is None

@boegel boegel changed the title Bugfix for MetalWalls easyblock take into account that f90wrap_version may be None in MetalWalls easyblock Oct 9, 2024
@boegel boegel added the bug fix label Oct 9, 2024
@boegel boegel added this to the release after 4.9.4 milestone Oct 9, 2024
@boegel
Copy link
Member

boegel commented Oct 9, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="MetalWalls-21.06.1-foss-2023a.eb"

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3468 EB_ARGS="MetalWalls-21.06.1-foss-2023a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3468 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5032

Test results coming soon (I hope)...

Details

- notification for comment with ID 2401392148 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel modified the milestones: release after 4.9.4, release after 5.0.0 Mar 18, 2025
@boegel boegel modified the milestones: next release (5.1.0), 5.x May 22, 2025
@Crivella
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3
EB_ARGS="MetalWalls-21.06.1-foss-2023a.eb"

@Crivella Crivella modified the milestones: 5.x, next release (5.1.1?) Jun 19, 2025
@boegelbot
Copy link

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3468 EB_ARGS="MetalWalls-21.06.1-foss-2023a.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3468 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6911

Test results coming soon (I hope)...

Details

- notification for comment with ID 2988450676 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS MetalWalls-21.06.1-foss-2023a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/96de6e21cea8a4c7a3ea078868c946ef for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 9524b9f into easybuilders:develop Jul 2, 2025
17 checks passed
@Crivella Crivella deleted the feature-MWfix branch July 2, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants