Skip to content

copy EasyConfig instance in constructor of Bundle and Cargo easyblocks before making changes to it #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
branfosj merged 1 commit into from
Sep 15, 2024
Merged

copy EasyConfig instance in constructor of Bundle and Cargo easyblocks before making changes to it #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions easybuild/easyblocks/generic/bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ def __init__(self, *args, **kwargs):
if self.cfg['patches']:
raise EasyBuildError("List of patches for bundle itself must be empty, found %s", self.cfg['patches'])

# copy EasyConfig instance before we make changes to it
# (like adding component sources to top-level sources easyconfig parameter)
self.cfg = self.cfg.copy()

# disable templating to avoid premature resolving of template values
self.cfg.enable_templating = False

Expand Down
3 changes: 3 additions & 0 deletions easybuild/easyblocks/generic/cargo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ def __init__(self, *args, **kwargs):
'filename': self.crate_src_filename(crate, version),
})

# copy EasyConfig instance before we make changes to it
self.cfg = self.cfg.copy()

self.cfg.update('sources', sources)

@property
Expand Down