Skip to content

remove stray newline in error message produced by PyTorch easyblock#3005

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20230919131235_new_pr_pytorch
Oct 10, 2023
Merged

remove stray newline in error message produced by PyTorch easyblock#3005
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:20230919131235_new_pr_pytorch

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Sep 19, 2023

(created using eb --new-pr)

Follow-up to #3003 as the error looked odd:

== 2023-09-19 02:10:45,186 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:126 in __init__): 3 test failures, 1 test error (out of 129449):
Failed tests (suites/files):
test_quantization (997 total tests, failures=2, errors=1, skipped=74)
distributed/_tensor/test_dtensor_ops (637 total tests, skipped=36, expected failures=407, unexpected successes=1)
test_ops_gradients (1 failed, 1892 passed, 3055 skipped, 42 xfailed, 1 warning, 2 rerun)

+ test_cpp_extensions_jit (at easybuild/easyblocks/p/pytorch.py:430 in test_step)

This PR removes the empty line by building up a list of everything and joining it once and always.

…list of strings to a single string value in PyTorch easyblock
@boegel boegel added the bug fix label Sep 27, 2023
@boegel boegel added this to the next release (4.8.2?) milestone Sep 27, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 27, 2023

@boegelbot please test @ generoso
EB_ARGS="PyTorch-1.13.1-foss-2022b.eb"
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3005 EB_ARGS="PyTorch-1.13.1-foss-2022b.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3005 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11786

Test results coming soon (I hope)...

Details

- notification for comment with ID 1737495529 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS PyTorch-1.13.1-foss-2022b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/8b066aece99a1f92a1e07d6233ee8620 for a full test report.

@boegel boegel changed the title remove stray newline in pytorch error message remove stray newline in error message produced by PyTorch easyblock Oct 10, 2023
@boegel boegel merged commit 47a43f6 into easybuilders:develop Oct 10, 2023
@Flamefire Flamefire deleted the 20230919131235_new_pr_pytorch branch October 11, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants