enable system pybind11 for PyTorch 1.10+ to make sure pybind11 provided as dependency is used#2968
Conversation
|
sounds good to me |
|
I'm currently running some builds to verify this doesn't break anything. Will mark this as ready once they succeeded. |
3e39d2d to
cfeb5a1
Compare
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
I tested 4 ECs with and without this PR on 2 architectures. Seems to work just fine, so I'd say this is good to go! |
|
Going in, thanks @Flamefire! |
pybind11 for PyTorch 1.10+ to make sure pybind11 provided as dependency is used
(created using
eb --new-pr)PyTorch switched to custom pybind11 by default in 1.10: pytorch/pytorch@7179e7e
But we provide our Pybind11, which was used before and IMO should still be used.
optarchvalue inCargoeasyblock #2969 due to unrelated CI failure