Skip to content

accept both None and empty value for optarch to let OpenCV detect host CPU#2804

Merged
casparvl merged 1 commit intoeasybuilders:developfrom
smoors:20221017140259_new_pr_opencv
Oct 17, 2022
Merged

accept both None and empty value for optarch to let OpenCV detect host CPU#2804
casparvl merged 1 commit intoeasybuilders:developfrom
smoors:20221017140259_new_pr_opencv

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Oct 17, 2022

(created using eb --new-pr)
this allows to remove the default optarch setting, for example in jsc-zen2 boegelbot

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Oct 17, 2022

I'll try to upload a test report for easybuilders/easybuild-easyconfigs#16393 on my local systems with this EasyBlock, and passing optarch=''. (note: the test report will probably end up in the EasyConfigs PR)

@casparvl
Copy link
Copy Markdown
Contributor

So far so good, I get -DCPU_BASELINE=DETECT in the configure step, as expected :)

@casparvl
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the next release (4.6.2?) milestone Oct 17, 2022
@casparvl casparvl merged commit 2493cbd into easybuilders:develop Oct 17, 2022
@boegel boegel changed the title allow empty optarch string for opencv accept both None and empty value for optarch to let OpenCV detect host CPU Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants