Skip to content

avoid excessively long shebang line in compile script for WRF#2648

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:20220106180947_new_pr_wrf
Jan 15, 2022
Merged

avoid excessively long shebang line in compile script for WRF#2648
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:20220106180947_new_pr_wrf

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jan 6, 2022

(created using eb --new-pr)

@boegel
Copy link
Member Author

boegel commented Jan 8, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS WRF-3.9.1.1-foss-2020b-dmpar.eb
  • SUCCESS WRF-3.9.1.1-intel-2020b-dmpar.eb
  • SUCCESS WRF-4.2.2-foss-2020b-dmpar.eb
  • SUCCESS WRF-4.3-foss-2021a-dmpar.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2602.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/e505db270a738d78d984892cbf60293b for a full test report.

@boegel boegel requested a review from ocaisa January 9, 2022 16:46
@ocaisa
Copy link
Member

ocaisa commented Jan 10, 2022

@boegel Code looks good to me, can you just confirm that you see what you expect in the final compile scripts (for both cases)?

@boegel
Copy link
Member Author

boegel commented Jan 15, 2022

  • for WRF-3.9.1.1-foss-2020b-dmpar.eb, with tcsh as proper build dependency provided by EasyBuild:
    $ head -1 software/WRF/3.9.1.1-foss-2020b-dmpar/WRFV3/compile
    #!/usr/bin/env tcsh
    
  • for WRF-3.9.1.1-foss-2020b-dmpar.eb, with --filter-deps tcsh to use tcsh provided by OS (so no patching done to compile script):
    $ head -1 software/WRF/3.9.1.1-foss-2020b-dmpar/WRFV3/compile
    #!/bin/csh -f
    
  • for WRF-3.9.1.1-foss-2020a-dmpar.eb in EESSI, where we're using --sysroot:
    $ head -1 /cvmfs/pilot.eessi-hpc.org/versions/2021.12/software/linux/x86_64/intel/skylake_avx512/software/WRF/3.9.1.1-foss-2020a-dmpar/WRFV3/compile
    #!/cvmfs/pilot.eessi-hpc.org/versions/2021.12/compat/linux/x86_64/usr/bin/env tcsh
    

Note that the lack of -f (which we need to drop when using /usr/bin/env tcsh) doesn't matter, from the tcsh man page:

-f  The shell does not load any resource or startup files, or perform any command hashing, and thus starts faster.

@ocaisa

@ocaisa ocaisa merged commit 3790a97 into easybuilders:develop Jan 15, 2022
@boegel boegel deleted the 20220106180947_new_pr_wrf branch January 15, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants