-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tcp/udp proxy feature #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 234 Deploy Test Success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to add new function in interface.
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 80.43% 80.57% +0.13%
==========================================
Files 70 70
Lines 8093 8171 +78
==========================================
+ Hits 6510 6584 +74
- Misses 1223 1230 +7
+ Partials 360 357 -3
Continue to review full report at Codecov.
|
@jxd134 There are some warnings in your code which reported by glint, could you please help to fix them? |
@haoel I will fix it in future commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 234 Deploy Test Success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 234 Deploy Test Success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 234 Deploy Test Success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test SUCCESS]megaease/easegress Pull Request 234 Deploy Test Success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 234 Deploy Test failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 234 Deploy Test failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 234 Deploy Test failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TASK:easegress-pr-test FAILED]megaease/easegress Pull Request 234 Deploy Test failed
…g/jxd134/easegress into resolve_merge_conflict
…wing and testing (thanks to @ samutamm)
I am now confused. |
Are you experiencing some specific reproducible error or is this more like a general question about the design? For directional channels the sender should close the channel but here the connections are bidirectional, right? |
yes, that's it |
There is no time to solve it in the short term, so I can only choose to give up. |
Add tcp/udp proxy feature
Show it for everyone to comment or correct.