Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #58

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Refactoring #58

wants to merge 32 commits into from

Conversation

teddychoi
Copy link
Member

Trying to clean the codes through

  1. Reconstruct API structure through extracting functions
  2. Remove unclear Cursor class
  3. Make exception handling briefer
  4. Make constructing json data procedure briefer
  5. Simplify entry generators

Some of them are started now, but none of them is done completely yet.
It will be my pleasure reviewing my code, or saying something more which are needed to be refactored.

@teddychoi
Prepare not using Cursor
4db3882
@teddychoi
Use Category, not Cursor in feeds API
4cab41c
@teddychoi
Extract functions in feeds API
1d9b750
@teddychoi
Rename API function name. feeds -> list_in_category
940caf3
@teddychoi
Rename cursor to category
5e8efdb
@teddychoi
Use category in add_feed API
88742c7
@teddychoi
Exceptions for errors when adding feed
e9fcf4b
@teddychoi
Function returning subscriptions
592b0c0
@teddychoi
Return empty SubscriptionList when there is None
0714441
@teddychoi
Get category using subscription list
697ebcf
@teddychoi
Refactoring add_feed API
600b231
@teddychoi
Replace Cursor with Category in add_category
17994be
@teddychoi
get_parent_category_id function
58538ff
@teddychoi
Replace cursor in delete_category
68c374e
@teddychoi
SubscriptionTransaction to manage subscriptions' change
e6df50a
@teddychoi
Reset subscriptions when save
4922c86
@teddychoi
Use transaction
6e248e6
@teddychoi
Replace Cursor with SubscriptionTransaction
f25d822
@teddychoi
PEP 8
105016e
@teddychoi
Simplify exception handling when feed not found in category
efdb72f
@teddychoi
Add status_code field in JsonException
d1349f3
@teddychoi
typo
0aaf199
@teddychoi
Simplify exception handlings
fa3eec5
@teddychoi
Use items(), not iteritems()
384305d
@teddychoi
Rename field
76320b8
@teddychoi
Get feed from transaction
8666d0b
@teddychoi
Update feed through transaction
28dd713
@teddychoi
Revert "Update feed through transaction"
a2164f6 
This reverts commit 28dd713.
Subscription merging fails in certain condition in Python3
@teddychoi
Revert "Revert "Update feed through transaction""
ece5e73 
This reverts commit a2164f6.
Bug fixed in libearth-0.3
@teddychoi
Use transaction in request context
28c9655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teddychoi