32-bit physics with FV3_RAP#180
Merged
RobertPincus merged 1 commit intoJun 24, 2022
Merged
Conversation
This was referenced Jun 24, 2022
Member
|
@SamuelTrahanNOAA The |
Author
|
This PR is a major change in FV3 and CCPP, so I don't want to add any other changes. Also, it is absolutely critical that this PR not change the results of any tests on any platform. I do agree that we need to update dtc/ccpp from master, but that is outside the scope of this PR, and belongs in another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for 32-bit physics to the FV3, based on prior work on the Neptune model. The 64-bit physics should not change results. The only change in this repository is to add a flag to enable single precision. The code for that was copied from the authoritative branch.
See the top-level PR here for details:
ufs-community/ufs-weather-model#1215
The issue for this is here:
ufs-community/ufs-weather-model#1288