Skip to content

CCPP metadata updates and bug fixes#133

Merged
dustinswales merged 2 commits into
earth-system-radiation:dtc/ccppfrom
climbfuji:merge_feature_capgen_into_main_20210812
Aug 16, 2021
Merged

CCPP metadata updates and bug fixes#133
dustinswales merged 2 commits into
earth-system-radiation:dtc/ccppfrom
climbfuji:merge_feature_capgen_into_main_20210812

Conversation

@climbfuji
Copy link
Copy Markdown
Contributor

@climbfuji climbfuji commented Aug 12, 2021 •
edited
Loading

A few updates and bug fixes to the CCPP metadata and the metadata hooks in the Fortran code, required for consistency and a future update of the ccpp-framework.

Also: convert rte/mo_optical_props.F90 from dos line endings to unix line endings (no code changes).

Associated PRs:

NCAR/ccpp-framework#391
#133
NCAR/ccpp-physics#718
NOAA-EMC/ufsatm#367
ufs-community/ufs-weather-model#745

For regression testing, see ufs-community/ufs-weather-model#745.

This was referenced Aug 12, 2021
Merged
Merged
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review August 12, 2021 21:56
dustinswales
dustinswales reviewed Aug 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems fine, except the change rte/mo_optical_props.F90. The changes should be isolated to the new "htmlinclude" for ty_optical_props_1scl/2str/nstr ccpp table properties.

@climbfuji
Copy link
Copy Markdown
Contributor Author

climbfuji commented Aug 12, 2021

This all seems fine, except the change rte/mo_optical_props.F90. The changes should be isolated to the new "htmlinclude" for ty_optical_props_1scl/2str/nstr ccpp table properties.

Do you want me to revert the dos/unix file endings change?

@dustinswales
Copy link
Copy Markdown
Contributor

dustinswales commented Aug 12, 2021

This all seems fine, except the change rte/mo_optical_props.F90. The changes should be isolated to the new "htmlinclude" for ty_optical_props_1scl/2str/nstr ccpp table properties.

Do you want me to revert the dos/unix file endings change?

Yes

@climbfuji
Copy link
Copy Markdown
Contributor Author

climbfuji commented Aug 16, 2021

This all seems fine, except the change rte/mo_optical_props.F90. The changes should be isolated to the new "htmlinclude" for ty_optical_props_1scl/2str/nstr ccpp table properties.

Do you want me to revert the dos/unix file endings change?

Yes

Done.

@climbfuji climbfuji requested a review from dustinswales August 16, 2021 19:34
@dustinswales dustinswales merged commit d9594c4 into earth-system-radiation:dtc/ccpp Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dustinswales dustinswales dustinswales approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@climbfuji @dustinswales