GCC_PKGREL must follow semver rules#14
Merged
Merged
Conversation
Replace leading zeroes with minor.major.patch 0-padding
mcspr
commented
Aug 4, 2020
| ISL := 0.12.2 | ||
| GCC_BRANCH := call0-4.8.2 | ||
| GCC_PKGREL := 00482 | ||
| GCC_PKGREL := 40802 |
Author
There was a problem hiding this comment.
This comes from:
https://bintray.com/platformio/dl-packages/toolchain-xtensa/
Owner
|
On a related note, does that |
Author
|
STAMP variable will be updated though:
>> import semantic_version
>> a = semantic_version.Version("5.100100.200706")
>> b = semantic_version.Version("5.100100.200804")
>> b > a
True
|
earlephilhower
approved these changes
Aug 4, 2020
Owner
earlephilhower
left a comment
There was a problem hiding this comment.
LGTM. Will need a full toolchain build to be integrated to the packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace leading zeroes with minor.major.patch 0-padding, because PlatformIO uses semantic version module for package version sorting.
Meaning, future 10.2 must be 100200
see platformio/platformio-core#3612 (comment)
Effectively, this does nothing atm, because we don't have a list of available versions and install happens by directly setting the version. I'd wait until response from PIO guys though, whether this package deployment can be simplified
(perhaps we will get a 'public' registry a-la npm or the option I proposed in the pio-core issue tracker)
Also, so I don't forget this fix is needed.