fix: Invalid data is assigned to the right channel when playing a mono MP3. #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Thanks for this great library and your work !
I have noticed that when I play a mono MP3, the right channel contains a buzzing sound.
PBMB3768.MOV
On the other hand, the AAC decoder appears to assign the same data to both channels from mono data.
So, in this pull request, I copied the data from the left channel to the right channel when the data is mono, so that the buzzer-like sound is not output.
I just couldn't decide if it would be best to make the change at this location in the source code.
If you like this modification, I would be happy to hear from you, but if you have any suggestions on where I should fix it, please direct me.
Best regards.