Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for various tiny fixes #357

Merged
merged 7 commits into from
Jan 2, 2021
Merged

Proposal for various tiny fixes #357

merged 7 commits into from
Jan 2, 2021

Conversation

d-a-v
Copy link
Contributor

@d-a-v d-a-v commented Jan 2, 2021

  • In the ICY recent fix, add a check for icyMetaInt that has been seen to be 0
  • Two short buffer size (seen by compiler when using emulation on host)
  • StreamOnHost example:
    • Make it slower so it can reveal some issue with some URL
    • Make it look like better with the real HTTP example
    • Always show cmdline help in the ./onHost script

earlephilhower
earlephilhower approved these changes Jan 2, 2021
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Is this good to go from you, or are you still finding things you want included?

@d-a-v
Copy link
Contributor Author

d-a-v commented Jan 2, 2021

It's good to me !

@earlephilhower earlephilhower merged commit 0cee4d4 into earlephilhower:master Jan 2, 2021
@d-a-v d-a-v deleted the emulationUpdates branch January 2, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-a-v @earlephilhower