Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for esp8266 I2S/NoDAC #344

Merged
merged 5 commits into from
Dec 12, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+message
d-a-v committed Dec 8, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit c6be0f6e28a0121e74a0a835c3e829b2f8307d38
4 changes: 3 additions & 1 deletion src/AudioOutputI2S.cpp
Original file line number Diff line number Diff line change
@@ -199,7 +199,9 @@ bool AudioOutputI2S::begin(bool txDAC)
#if I2S_HAS_BEGIN_RXTXDAC
i2s_rxtxdac_begin(false, true, txDAC);
#else
(void)txDAC;
if (!txDAC) {
audioLogger->printf_P(PSTR("I2SNoDAC: esp8266 arduino core should be upgraded to avoid conflicts with SPI\n"));
}
i2s_begin();
#endif
}