Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a problem while parsing tags in mp3 files with embedded images (
APIC
frames), with my program freezing.It appears that the
for loop
which populate thevalue
buffer has anint16_t
as a counter, thus overflowing when frame size is above 65535 bytes. I've changed it to anint32_t
.Besides, I needed some other tags to be extracted for my projects, I've thus added the following ones :
TRCK / TRK
track number (+ total tracks)TPOS / TPA
part of a set (+ total set) i.e. if the album has several discs.POPM / POP
popularimeter, aka rating.TCMP
"part of a compilation". It's not clear if this one is an off-standard added by iTunes, or if it's included in ID3v4