Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP8266Audio compilation error in V3.0.0-Release of Arduino-esp32 #683

Closed
Zhentao-Lin opened this issue May 31, 2024 · 2 comments · Fixed by #685
Closed

ESP8266Audio compilation error in V3.0.0-Release of Arduino-esp32 #683

Zhentao-Lin opened this issue May 31, 2024 · 2 comments · Fixed by #685

Comments

@Zhentao-Lin
Copy link

Zhentao-Lin commented May 31, 2024 •
edited
Loading

This is a very practical and easy to use library, I really enjoy using it to do some audio development.
Today, after updating my Arduino-esp32 to version 3.0.0-Release, I found that the compilation failed. As my personal ability level is limited, I ask for your help. Here is my error message.

1

Thank you again.
@earlephilhower
Copy link
Owner

Espressif seems to have broken existing code with the (IMHO reasonable and a good idea in the long term!) change from WiFiClient to NetworkClient in 3.0.0. Since they have an entire Ethernet MAC onboard in addition to the WiFi radio, it makes sense. On the Pico we ended up keeping WiFiClient and just letting it work on anything, wired or wireless.

All network code for the ESP32 will need to be rewritten to use the new class names. I'm not really an ESP32 user so hopefully someone here will have the time and knowledge to to the transition and throw a PR out...

@Lebo77
Copy link

Lebo77 commented Jun 6, 2024 •
edited
Loading

If I don't use the WiFi functions in this library (all the audio I am playing is local) is there a workaround to comment out all the network stuff?

Edit: OK, the compilation errors go well beyond just the networking stuff. Errors in SPIFFS and I2C output as well.

earlephilhower added a commit that referenced this issue Jun 6, 2024
@earlephilhower
Update for ESP32 Arduino 3.x
6658956 
Implement the renamed network client and other API changes when built
under the 3.x branch of the Arduino ESP32 core.

Disable building TSF, the Xtensa G++ backend bug is still there.

Minimal changes to get I2S to build under new IDF.  Deprecated but
not removed, so warnings are expected but should not be fatal in
use.

Fixes #683
@earlephilhower earlephilhower mentioned this issue Jun 6, 2024
Merged
earlephilhower added a commit that referenced this issue Jun 6, 2024
@earlephilhower
Update for ESP32 Arduino 3.x (#685)
a614147 
Implement the renamed network client and other API changes when built
under the 3.x branch of the Arduino ESP32 core.

Disable building TSF on the ESP32, the Xtensa G++ backend bug is still there.

Minimal changes to get I2S to build under new IDF.  Deprecated but
not removed, so warnings are expected but should not be fatal in
use.

Fixes #683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update for ESP32 Arduino 3.x earlephilhower/ESP8266Audio
3 participants
@earlephilhower @Lebo77 @Zhentao-Lin