Repository navigation
fix(coding-agent): inherit subagent session config - #7897
Merged
badlogic merged 1 commit intoAug 11, 2026
Merged
Conversation
Collaborator
|
cheers! |
dadezzz
pushed a commit
to dadezzz/forgejo-agent
that referenced
this pull request
Aug 19, 2026
![Renovate [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
….2 (#213) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@earendil-works/pi-coding-agent](https://github.com/earendil-works/pi) ([source](https://github.com/earendil-works/pi/tree/HEAD/packages/coding-agent)) | [`0.84.1` → `0.84.2`](https://renovatebot.com/diffs/npm/@earendil-works%2fpi-coding-agent/0.84.1/0.84.2) |  |  | --- ### Release Notes <details> <summary>earendil-works/pi (@​earendil-works/pi-coding-agent)</summary> ### [`v0.84.2`](https://github.com/earendil-works/pi/blob/HEAD/packages/coding-agent/CHANGELOG.md#0842---2026-08-14) [Compare Source](earendil-works/pi@v0.84.1...v0.84.2) ##### New Features - **Fullscreen transcript search** — Search and navigate matches in fullscreen mode. See [TUI Fullscreen Viewport](docs/keybindings.md#tui-fullscreen-viewport). - **Configurable default tools** — Choose startup built-in tools globally or per project. See [Tools](docs/settings.md#tools). - **Configurable fullscreen exit output** — Print the transcript or only a resume hint on exit. See [Interactive Mode](docs/usage.md#interactive-mode). ##### Added - Added fullscreen transcript search with `Ctrl+Shift+F`, incremental match highlighting, configurable search match theme colors, and next/previous navigation with `Enter`/`Ctrl+G` and `Shift+Enter`/`Ctrl+Shift+G`. - Added experimental strict JSON-schema constrained sampling for the default `read`, `bash`, `edit`, and `write` tools under `PI_EXPERIMENTAL=1`. - Added a fullscreen exit output setting to choose between printing the final transcript and only a session resume hint. - Added the `defaultTools` setting for configuring the initial built-in tool selection globally or per project. - Added `--use-theme <name[/name]>` to choose an initial per-run interactive theme without changing saved settings ([#​7722](earendil-works/pi#7722) by [@​rwachtler](https://github.com/rwachtler)). - Added `expandPromptTemplates` to extension `pi.sendUserMessage()` options for explicitly dispatching commands and expanding skills and prompt templates. See [`pi.sendUserMessage()`](docs/extensions.md#pisendusermessagecontent-options) ([#​7857](earendil-works/pi#7857) by [@​mrexodia](https://github.com/mrexodia)). - Added inherited `createGatewayBindingFetch()` for routing Cloudflare AI Gateway requests through a Workers AI binding without an API token ([#​7901](earendil-works/pi#7901) by [@​Maximo-Guk](https://github.com/Maximo-Guk)). - Added inherited `AssistantMessage.endTurn` to preserve OpenAI Codex's terminal `end_turn` signal for diagnostics ([#​7766](earendil-works/pi#7766)). - Added inherited unbound single-line transcript scrolling actions for fullscreen mode. See [TUI Fullscreen Viewport](docs/keybindings.md#tui-fullscreen-viewport) ([#​7903](earendil-works/pi#7903) by [@​midastruth](https://github.com/midastruth)). ##### Changed - Changed inherited Kimi Coding requests to use pi's runtime `User-Agent` header. - Replaced the inherited Mistral SDK transport with a native Chat Completions HTTP stream, eliminating its generated client and schema runtime overhead. - Documented the generic `AI_AGENT=pi` process marker and how it differs from `PI_CODING_AGENT=true` ([#​7747](earendil-works/pi#7747)). - Changed inherited OpenAI Responses deferred tool loading to prefer message-anchored `additional_tools` where supported while retaining tool-search and top-level fallbacks ([#​7709](earendil-works/pi#7709)). - Reduced inherited fullscreen rendering allocation churn by painting full-width layout rows directly instead of recompositing them on every frame. ##### Fixed - Fixed root Markdown files such as `README.md` and `AGENTS.md` in skill directories being reported as broken skills unless they declare valid skill frontmatter ([#​7805](earendil-works/pi#7805)). - Fixed single-object `edit` tool inputs failing validation by accepting them as one-edit arrays in both coding-agent and harness edit tools ([#​7835](earendil-works/pi#7835)). - Fixed managed-tool downloads delaying TUI startup and hiding diagnostics in fullscreen mode by mounting the TUI first and showing download progress and warnings inside it. - Fixed opening a model selector immediately after startup cancelling and restarting the in-progress model catalog refresh. - Fixed inherited GitHub Copilot login triggering API rate limits while enabling model policies by limiting concurrent policy updates ([#​6187](earendil-works/pi#6187)). - Fixed fullscreen transcript search snapping back to the current match during manual scrolling and fragmented mouse input leaking into the search query. - Fixed inherited required LaTeX arguments starting on a new line being parsed as empty ([#​7760](earendil-works/pi#7760)). - Updated the transitive `nanoid` development dependency to address a denial-of-service vulnerability. - Fixed fallback rendering for extension tool results to collapse long output and honor tool expansion ([#​7979](earendil-works/pi#7979)). - Fixed JSON and RPC `message_update` events dropping cumulative usage during streaming. See [JSON Event Mode](docs/json.md) and [RPC `message_update`](docs/rpc.md#message_update-streaming) ([#​7982](earendil-works/pi#7982) by [@​christianklotz](https://github.com/christianklotz)). - Fixed `pi.sendMessage(..., { triggerTurn: false })` steering an active run instead of only recording the custom message ([#​8022](earendil-works/pi#8022) by [@​cristinaponcela](https://github.com/cristinaponcela)). - Fixed the `defaultTools` setting dropping extension and SDK custom tools when selecting built-in defaults. - Fixed the subagent example rejecting YAML array syntax for the `tools` frontmatter field ([#​7598](earendil-works/pi#7598) by [@​alexsavio](https://github.com/alexsavio)). - Fixed the subagent example dropping parent session model, thinking, and tool configuration ([#​7897](earendil-works/pi#7897) by [@​virtuald](https://github.com/virtuald)). - Fixed custom system prompts concatenating the current working directory with later appended prompt content ([#​7887](earendil-works/pi#7887) by [@​distributedlock](https://github.com/distributedlock)). - Fixed inherited OpenAI Responses function and custom tool calls losing namespaces during streaming, proxying, and replay ([#​7709](earendil-works/pi#7709)). - Fixed inherited upstream request buffer failures not triggering automatic assistant retries. - Fixed inherited built-in and custom DeepSeek API models sending output limits through an unsupported field. - Fixed inherited Amazon Bedrock replay rejecting tool arguments that contain empty object keys while preserving all valid nested values ([#​7882](earendil-works/pi#7882) by [@​muyiyr](https://github.com/muyiyr)). - Fixed inherited DeepSeek compatibility detection for base URLs whose hostname contains uppercase letters ([#​7933](earendil-works/pi#7933) by [@​yearth](https://github.com/yearth)). - Fixed inherited Google Generative AI and Vertex AI responses with tool calls incorrectly treating output-limit or provider-error stops as normal tool use ([#​8059](earendil-works/pi#8059)). - Fixed inherited fullscreen mouse drag selection and OSC 8 link activation in terminals that report generic SGR mouse release button codes ([#​7963](earendil-works/pi#7963)). - Fixed inherited focused fullscreen overlays not receiving mouse wheel or viewport scroll keys such as PageUp and PageDown ([#​7894](earendil-works/pi#7894)). - Fixed inherited LaTeX control spaces split across line endings causing complete expressions to fall back to raw source. - Fixed split `Alt+Enter` input over SSH being misread as Escape, added `PI_TUI_ESC_TIMEOUT` for high-latency terminals, and limited that timeout to lone Escape input ([#​7899](earendil-works/pi#7899) by [@​powerfooI](https://github.com/powerfooI)). - Fixed inherited idle fullscreen sessions repainting and clearing text selection when the terminal loses focus ([#​7892](earendil-works/pi#7892) by [@​terrorobe](https://github.com/terrorobe)). - Fixed fullscreen selection copy to use the host clipboard and report failure instead of claiming success when OSC 52 is unsupported ([#​8110](earendil-works/pi#8110) by [@​Panoplos](https://github.com/Panoplos)). </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4zMS4wIiwidXBkYXRlZEluVmVyIjoiNDQuMzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
1 task
jinhuang712
pushed a commit
to jinhuang712/pi
that referenced
this pull request
Sep 11, 2026
4xguy
added a commit
to 4xguy/pi-mono
that referenced
this pull request
Sep 23, 2026
Conflicts resolved: - .pi/prompts/cl.md: kept deleted. Fork commit 4c05966 ("chore(pi): remove project-loaded extension and prompt duplicates") deliberately removed this file as a project-local duplicate; upstream (aa23e78) only updated a repo link inside the file the fork no longer wants. This is the opposite of a fork customization to preserve, so the fork's deletion stands. - packages/coding-agent/CHANGELOG.md: kept both sides' [0.84.1] Added entries (fork's PI_* env exposure and subagent guardrail entries, upstream's terminate/selection/scrolling entries), upstream's listed first. - packages/coding-agent/examples/extensions/subagent/{agents,index}.ts: kept the fork's guardrail architecture (options-object runSingleAgent, richer AgentConfig fields, wave scheduler, worktree isolation) and folded in upstream's API changes: agents.ts now parses frontmatter as `unknown` (matching the real YAML parser) with upstream's robustness comments, extended to the fork's extra fields (disallowedTools, thinking, mode, writePaths, isolation, timeoutMs, useProactively). index.ts/profiles.ts/types.ts gained upstream's "inherit subagent session config" fix (earendil-works#7897): a new DispatchDefaults type carries the parent session's active model/thinking level as the final fallback tier in resolveTaskExecution(), after per-task and per-agent overrides. - packages/coding-agent/examples/extensions/subagent/README.md: kept the fork's structure; merged in upstream's note that an omitted model inherits the dispatching session's model/thinking (moved under Task Overrides, next to the fields it documents); dropped upstream's duplicate confirmation-flow and agent-location text already covered under Security Model. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
oskarfreye
pushed a commit
to draht-dev/draht
that referenced
this pull request
Oct 1, 2026
hamishfromatech
pushed a commit
to hamishfromatech/a-coder-cli
that referenced
this pull request
Oct 3, 2026
(cherry picked from commit e3798ca)
qaworkfree
pushed a commit
to qaworkfree/pipipiPopopo
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I prefer the subagents to follow the current model/thinking instead of specifying them explicitly. Currently, if I have several sessions open the subagent will follow whatever the last model/thinking level that an arbitrary session set, which isn't very intuitive.
My clanker wrote this, but it seems straightforward enough, and I tested it and it seemed to work. The clanker wrote a set of tests for the extension, but I didn't include them because there aren't existing tests.
The subagent extension is half-baked, but still useful, and I hope you accept this minor change.