Skip to content

fix(ai): send max_tokens for Z.AI providers #7174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
badlogic merged 2 commits into from
Jul 28, 2026
Merged

fix(ai): send max_tokens for Z.AI providers #7174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bfae0d
fix(ai): send max_tokens for Z.AI providers
HyeokjaeLee Jul 26, 2026
2ffe87b
fix(ai): set zai max_tokens compat in model generator
HyeokjaeLee Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ai/scripts/generate-models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ function detectOpenAICompletionsCompat(model: Model<"openai-completions">): Open
isAntLing;

const useMaxTokens =
baseUrl.includes("chutes.ai") || isMoonshot || isCloudflareAiGateway || isTogether || isNvidia || isAntLing;
baseUrl.includes("chutes.ai") || isMoonshot || isCloudflareAiGateway || isTogether || isNvidia || isAntLing || isZai;

const isGrok = provider === "xai" || baseUrl.includes("api.x.ai");
const isDeepSeek = provider === "deepseek" || baseUrl.includes("deepseek.com");
Expand Down
8 changes: 7 additions & 1 deletion packages/ai/src/api/openai-completions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,13 @@ function detectCompat(model: Model<"openai-completions">): ResolvedOpenAIComplet
isAntLing;

const useMaxTokens =
baseUrl.includes("chutes.ai") || isMoonshot || isCloudflareAiGateway || isTogether || isNvidia || isAntLing;
baseUrl.includes("chutes.ai") ||
isMoonshot ||
isCloudflareAiGateway ||
isTogether ||
isNvidia ||
isAntLing ||
isZai;

const isGrok = provider === "xai" || baseUrl.includes("api.x.ai");
const isDeepSeek = provider === "deepseek" || baseUrl.includes("deepseek.com");
Expand Down
27 changes: 27 additions & 0 deletions packages/ai/test/openai-completions-tool-choice.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,6 +1389,33 @@ describe("openai-completions tool_choice", () => {
}
});

it("sends max_tokens for Z.AI completions models", async () => {
const cases = [getModel("zai", "glm-5.1")!, getModel("zai", "glm-5.2")!] as const;

for (const model of cases) {
expect(model.compat?.maxTokensField).toBe("max_tokens");
let payload: unknown;

await streamSimple(
model,
{
messages: [{ role: "user", content: "Hi", timestamp: Date.now() }],
},
{
apiKey: "test",
maxTokens: 123,
onPayload: (params: unknown) => {
payload = params;
},
},
).result();

const params = (payload ?? mockState.lastParams) as { max_tokens?: number; max_completion_tokens?: number };
expect(params.max_tokens).toBe(123);
expect(params.max_completion_tokens).toBeUndefined();
}
});

it("omits reasoning effort for OpenCode Grok Build", async () => {
const model = getModel("opencode", "grok-build-0.1")!;
let payload: unknown;
Expand Down