On windows dependent extensions pulled in by an npm package mislabeled and show absolute path in banner

[avtc]

What happened?

On windows dependent extensions pulled in by an npm package mislabeled and show absolute path in [Extensions] banner.

Steps to reproduce

On Windows do pi install npm:avtc-pi-user-decisions (it references sibling extension to be installed in pi.extensions: ../avtc-pi-ui-components/index.ts)

On starting pi extensions lists looks like:

[Extensions]
avtc-pi-user-decisions, avtc-pi-user-decisions:C:\...\node_modules\avtc-pi-ui-components\index.ts

Expected behavior

Expected to see:

[Extensions]
avtc-pi-user-decisions, avtc-pi-ui-components

Version

0.80.6

[github-actions]

This issue was auto-closed. All issues from new contributors are auto-closed by default.

Maintainers review auto-closed issues daily and reopen worthwhile ones. Issues that do not meet the quality bar in CONTRIBUTING.md will not be reopened or receive a reply.

If a maintainer replies lgtmi on one of your issues, your future issues will stay open. If a maintainer replies lgtm, your future issues and PRs will stay open.

See CONTRIBUTING.md.

[avtc]

The issue root cause was identified:

1. getShortPath (packages/coding-agent/src/modes/interactive/interactive-mode.ts) - the node_modules/ regex is forward-slash only; Windows backslash paths miss - falls back to the absolute path.
2. getCompactExtensionLabel - labels by sourceInfo.source (the referencing package) instead of the package the file lives in, so a hoisted companion collapses to the host's label.

Fix ready on branch normalize-Windows-paths-and-label-npm-extensions-by-actual-package:

1. normalize \ to / before the regexes;
2. derive the npm label from the actual node_modules/<pkg>/ segment.
   New tests pass, no new failures. Can open a PR.

[davidbrai]

@badlogic I don't know how common this use case is. one extension is referencing another extension from pi.extensions into ../other-ext/index.ts. I can imagine two possible ways to display the packages here.

1. display as if they were two separate extensions:

at startup:

[Extensions]
avtc-pi-user-decisions, avtc-pi-ui-components

with pi --verbose:

npm:avtc-pi-user-decisions
  index.ts
npm:avtc-pi-ui-components
  index.ts

2. show that one is actually referenced from the other:

at startup:

[Extensions]
avtc-pi-user-decisions, avtc-pi-user-decisions:../avtc-pi-ui-components/index.ts

with pi --verbose:

npm:avtc-pi-user-decisions
  index.ts
  ../avtc-pi-ui-components/index.ts

wdyt?

[avtc]

Please note that different extensions could referense dependent extension, and it could be installed as standalone extension as well:
I.e.: ExtA -> ExtC, ExtB -> ExtC, ExtC
They all link to hoisted extension ExtC placed on the same root level as ExtA, ExtB.