New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove() returns item removed. #13

Merged

eapache merged 1 commit into eapache:master from gammazero:master

Aug 5, 2016

Contributor

gammazero commented Aug 4, 2016

The reason I am suggesting this change is because for many of my uses of queue, I remove an item in each iteration of a loop:

for q.Length() > 0 {
    x := q.Remove()
    ...

Only in some cases (e.g. your channels) do I find a need to do a Peek() and remove separately.


          Remove() returns item removed.

9036dda

Owner

eapache commented Aug 5, 2016

Looks great.

eapache merged commit 44cc805 into eapache:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet