Avoid memory leaks in semaphore

eapache · Aug 9, 2023 · 7756df1 · 7756df1
1 parent f5d2ae0
commit 7756df1
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/semaphore/semaphore.go b/semaphore/semaphore.go
@@ -29,10 +29,15 @@ func New(tickets int, timeout time.Duration) *Semaphore {
 // If it cannot after "timeout" amount of time, it returns ErrNoTickets. It is
 // safe to call Acquire concurrently on a single Semaphore.
 func (s *Semaphore) Acquire() error {
+	timer := time.NewTimer(s.timeout)
 	select {
 	case s.sem <- struct{}{}:
+		if !timer.Stop() {
+			<-timer.C
+		}
+
 		return nil
-	case <-time.After(s.timeout):
+	case <-timer.C:
 		return ErrNoTickets
 	}
 }