Skip to content

[ignore] add hint to issue template context section #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reinhapa merged 3 commits into from
Jan 31, 2023
Merged

[ignore] add hint to issue template context section #4657

reinhapa merged 3 commits into from
Jan 31, 2023

Conversation

@line-o
Copy link
Member

@line-o line-o commented Dec 18, 2022

add a hint that the context can be conveniently gathered using xst info
see eXist-db/xst#49

@line-o line-o changed the title context with a hint for xst info [doc] add hint to issue template context section Dec 18, 2022
@line-o line-o changed the title [doc] add hint to issue template context section [ignore] add hint to issue template context section Dec 18, 2022
adamretter
adamretter reviewed Dec 19, 2022
View reviewed changes
dizzzz
dizzzz requested changes Dec 22, 2022
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@line-o
Copy link
Member Author

line-o commented Dec 22, 2022

@dizzzz yes... I gave it a thumbs up already no need to get loud.

@line-o
Copy link
Member Author

line-o commented Dec 22, 2022

I will put this into draft until the actual feature in xst is available.

@line-o line-o marked this pull request as draft December 22, 2022 14:07
@line-o line-o marked this pull request as ready for review January 17, 2023 14:34
@line-o line-o requested review from adamretter and dizzzz January 17, 2023 14:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 17, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@line-o
Copy link
Member Author

line-o commented Jan 20, 2023 •
edited
Loading

see xst info output in #4694 for a preview

@line-o line-o requested a review from a team January 23, 2023 11:33
@line-o
Copy link
Member Author

line-o commented Jan 31, 2023

This PR is now open for 2 weeks and has two approvals.

@reinhapa
Copy link
Member

reinhapa commented Jan 31, 2023

@line-o seems that you need to update the current develop as here your #4696 seems to missing...

@line-o
Copy link
Member Author

line-o commented Jan 31, 2023 •
edited
Loading

For this change, as it only affects the GitHub issue template, it makes no difference. This will solve itself by merging it into develop.

@line-o
Copy link
Member Author

line-o commented Jan 31, 2023

I do not have that branch checked out. I edited the issue template directly on github.

@reinhapa reinhapa merged commit df7d9ee into develop Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizzzz dizzzz dizzzz approved these changes

@reinhapa reinhapa reinhapa approved these changes

@adamretter adamretter Awaiting requested review from adamretter

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@line-o @reinhapa @adamretter @dizzzz