-
-
Notifications
You must be signed in to change notification settings - Fork 190
[4.x.x] Improve security and configurability of functions that access the Environment and System Properties #4449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
adamretter
wants to merge
12
commits into
eXist-db:develop-4.x.x
Choose a base branch
from
evolvedbinary:4.x.x/feature/security/env-prop
base: develop-4.x.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le should be deterministic within the execution scope
…se are not Java System Properties
…n:available-environment-variables#0 and fn:environment-variable#1 to be configured from conf.xml
…fn:available-system-properties#0 and fn:system-property#1 to be configured from conf.xml
ljo
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I propose to close this PR without further action as exist-db v4 is EOL and no longer maintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
issue confirmed as bug
close-without-action
Proposed to be closed without further action. This will be voted on on the next community call.
enhancement
new features, suggestions, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds better security controls for accessing Environment Variables and Java System Properties.
fn:environment-variable#1
.fn:available-environment-variables#0
andfn:enviroment-variable#1
are now deterministic.util:available-system-properties#0
.util:available-system-properties#0
andutil:system-property#1
are now deterministic.fn:available-environment-variables#0
andfn:environment-variable#1
to be configured fromconf.xml
fn:available-system-properties#0
andfn:system-property#1
to be configured fromconf.xml