Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS appbundler limitation means Oracle JDK 8 is mandatory #2695

Closed
joewiz opened this issue May 16, 2019 · 6 comments
Closed

macOS appbundler limitation means Oracle JDK 8 is mandatory #2695

joewiz opened this issue May 16, 2019 · 6 comments
Assignees
Milestone

Comments

@joewiz
Copy link
Member

joewiz commented May 16, 2019

What is the problem

eXist uses appbundler for the macOS .app distribution. The appbundler's launch method used by eXist has a hidden dependency on Oracle JDK 8 and will thus prevent eXist from launching without it. This has affected eXist since v3.0.4, if not earlier versions.

I've submitted a PR to appbundler fixing the issue: https://bitbucket.org/infinitekind/appbundler/pull-requests/55. There's no ETA for this merge, but I hope it is in time for the release of 4.7.0 and 5.0.0-RC8. Once it is merged in, the mavenized branch of eXist will immediately pick it up, but the develop-4.x branch will need its tools/appbundler jar to be updated. I can do this as I did with #2187.

Update (2019-05-31): My PR to appbundler has been merged, so I've now submitted a corresponding PR for develop-4.x.x, #2768 - an important bugfix for users of 4.x.

Context information

  • eXist-db version + Git Revision hash: all since v3.0.4, if not earlier versions
  • Java version: all
  • Operating system: macOS
  • 32 or 64 bit: 64 bit
  • How is eXist-db installed? DMG or locally built .app
  • Any custom changes in e.g. conf.xml: none
@joewiz joewiz added the in progress Issue is actively being worked upon label May 16, 2019
@joewiz joewiz added this to the eXist-4.7.0 milestone May 16, 2019
@joewiz joewiz self-assigned this May 16, 2019
@adamretter
Copy link
Contributor

adamretter commented May 16, 2019

@joewiz Actually for the Mavenized branch we will need a new version of the appbundler-maven-plugin

@joewiz joewiz modified the milestones: eXist-4.7.0, eXist-4.7.1 May 24, 2019
joewiz added a commit to joewiz/exist that referenced this issue May 31, 2019
@joewiz
Copy link
Member Author

joewiz commented May 31, 2019

@adamretter I've submitted a PR for develop-4.x.x systems. I'm not sure what actions are needed for appbundler-maven-plugin to ensure this change is propagated to develop?

@adamretter
Copy link
Contributor

@joewiz I have published updated releases of the AppBundler, and the PRs to update eXist-db are here: #2769 and #2770

@joewiz
Copy link
Member Author

joewiz commented Jun 1, 2019

My PR #2768 in fact contained a regression in recent commits to appbundler. I've reported this bug to the upstream project and will submit a revised PR for 4.x.x when appbundler is fixed.

@adamretter
Copy link
Contributor

@joewiz Do we still need an update?

@joewiz
Copy link
Member Author

joewiz commented Jul 19, 2019

@joewiz joewiz closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants