Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] added syntax highlighting to query results #491

Merged
merged 2 commits into from
Jul 3, 2022

Conversation

ccheraa
Copy link
Contributor

@ccheraa ccheraa commented Jun 29, 2022

This adds syntax highlighting to query results.

Closes #147.

This open source contribution to the eXide project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.

@joewiz
Copy link
Member

joewiz commented Jun 30, 2022

@ccheraa Very nice! Just one issue upon a very quick review:

It seems that text in the results pane cannot be selected - so copy and paste of content from the results pane is not possible. Could you look into restoring the ability to select spans of text in the results pane?

Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text selection works perfectly. Syntax highlighting of results has no discernible effect on performance.

@joewiz joewiz merged commit a07551d into eXist-db:develop Jul 3, 2022
@joewiz
Copy link
Member

joewiz commented Jul 3, 2022

@ccheraa Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to xqlint for syntax highlighting of query results
2 participants