Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21267] Add Ubuntu weekly ci #5038

Merged
merged 5 commits into from
Jul 11, 2024
Merged

[21267] Add Ubuntu weekly ci #5038

merged 5 commits into from
Jul 11, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 8, 2024

Description

This PR addresses the following points related to the github CI:

  • Change windows reusable ci to use new merge meta files eProsima CI action
  • Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x
  • move the if (!skip-ci) inside the reusable workflows (as done in other repos with the run-build input), but keep the if (!conflicts) in the PR workflow so the GitHub CI requirement is not satisfied if skipped by conflicts.
  • Refactor ubuntu ci - python build job:
    build packages-select fastdds_python package

@Mergifyio backport 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jul 8, 2024
@Mario-DL Mario-DL changed the title [21267] Update Ubuntu weekly ci [21267] Add Ubuntu weekly ci Jul 8, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 9, 2024
.github/workflows/reusable-ubuntu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/weekly-ubuntu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/weekly-ubuntu-ci.yml Show resolved Hide resolved
.github/workflows/reusable-ubuntu-ci.yml Show resolved Hide resolved
.github/workflows/reusable-ubuntu-ci.yml Show resolved Hide resolved
.github/workflows/reusable-ubuntu-ci.yml Outdated Show resolved Hide resolved
@Mario-DL Mario-DL requested review from JesusPoderoso and removed request for JesusPoderoso July 9, 2024 08:36
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 10, 2024
@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 2.14.x 2.10.x

Copy link
Contributor

mergify bot commented Jul 10, 2024

backport 2.14.x 2.10.x

✅ Backports have been created

@EduPonz EduPonz merged commit e6773fb into master Jul 11, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the feature/21267 branch July 11, 2024 08:06
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

# Conflicts:
#	.github/workflows/nightly-ubuntu-ci.yml
#	.github/workflows/reusable-ubuntu-ci.yml
#	.github/workflows/reusable-windows-ci.yml
#	.github/workflows/weekly-ubuntu-ci.yml
mergify bot pushed a commit that referenced this pull request Jul 11, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

# Conflicts:
#	.github/workflows/nightly-ubuntu-ci.yml
#	.github/workflows/reusable-ubuntu-ci.yml
#	.github/workflows/reusable-windows-ci.yml
#	.github/workflows/weekly-ubuntu-ci.yml
JesusPoderoso pushed a commit that referenced this pull request Jul 11, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)
JesusPoderoso pushed a commit that referenced this pull request Jul 11, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)
JesusPoderoso pushed a commit that referenced this pull request Jul 11, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)
JesusPoderoso pushed a commit that referenced this pull request Jul 11, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)
EduPonz pushed a commit that referenced this pull request Jul 15, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

Co-authored-by: Mario Domínguez López <[email protected]>
EduPonz pushed a commit that referenced this pull request Jul 15, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

Co-authored-by: Mario Domínguez López <[email protected]>
mergify bot added a commit that referenced this pull request Jul 15, 2024
* Refs #21267: Add weekly ubuntu CI to test 2.x branches with CDR 1.1.x

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Change windows reusable ci to use new merge meta files eProsima CI action

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: move the !(skip_ci) inside the reusable workflows

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: compile fastdds_python package only

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21267: Apply Jesus suggestions

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e6773fb)

Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit 064ce70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants