Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21188] Example Refactor: Request-Reply #5014

Merged
merged 46 commits into from
Jul 16, 2024
Merged

Conversation

EduPonz
Copy link
Member

@EduPonz EduPonz commented Jul 1, 2024

Description

This PR refactors the request-reply example.
It also adds a Add DomainParticipantFactory::get_participant_extended_qos_from_default_profile

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jul 1, 2024
@elianalf elianalf changed the title [21188] Request-Reply example [21188] Example Refactor: Request-Reply Jul 1, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jul 2, 2024
Copy link
Contributor

@elianalf elianalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.
The include of the subdirectory RequestReplyExample has not been removed from /exampels/cpp/dds/CMakeLists.txt.

examples/cpp/request_reply/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/request_reply/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/request_reply/CLIParser.hpp Show resolved Hide resolved
examples/cpp/request_reply/CLIParser.hpp Show resolved Hide resolved
examples/cpp/request_reply/ServerApp.cpp Show resolved Hide resolved
examples/cpp/request_reply/ServerApp.cpp Show resolved Hide resolved
examples/cpp/request_reply/ServerApp.cpp Outdated Show resolved Hide resolved
examples/cpp/request_reply/ServerApp.cpp Show resolved Hide resolved
examples/cpp/request_reply/ClientApp.cpp Show resolved Hide resolved
examples/cpp/request_reply/README.md Show resolved Hide resolved
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label Jul 4, 2024
@EduPonz EduPonz requested a review from elianalf July 10, 2024 13:01
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 10, 2024
@EduPonz
Copy link
Member Author

EduPonz commented Jul 11, 2024

All CI except the example's test passed for commit 05ba0c0.

I've increased the timeouts and ask for a manual run on the example's test here

@EduPonz
Copy link
Member Author

EduPonz commented Jul 12, 2024

Another manual CI here

@EduPonz
Copy link
Member Author

EduPonz commented Jul 12, 2024

Another manual try here

test/examples/request_reply.compose.yml Outdated Show resolved Hide resolved
test/examples/test_request_reply.py Outdated Show resolved Hide resolved
test/examples/test_request_reply.py Outdated Show resolved Hide resolved
test/examples/test_request_reply_isolated.py Outdated Show resolved Hide resolved
Signed-off-by: eduponz <[email protected]>
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 16, 2024
@EduPonz EduPonz removed the ci-pending PR which CI is running label Jul 16, 2024
@EduPonz EduPonz merged commit 0bd9128 into master Jul 16, 2024
14 of 17 checks passed
@EduPonz EduPonz deleted the examples/request_reply branch July 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants