Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting vendor_id on received CacheChange_t [21214] #4978

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Setting vendor_id on received CacheChange_t [21214] #4978

merged 3 commits into from
Jul 4, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 21, 2024 •
edited by EduPonz
Loading

Description

MessageReceiver is setting the vendor _id for all RTPS submessages but for Data and DataFrag. This PR sets the vendor_id for this last submessages.

@Mergifyio backport 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Setting vendor_id on received CacheChange_t Setting vendor_id on received CacheChange_t [21214] Jun 21, 2024
@richiware richiware added this to the v3.0.0 milestone Jun 21, 2024
@richiware richiware added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Jun 21, 2024
@richiware richiware mentioned this pull request Jun 24, 2024
Merged
7 tasks
@richiware richiware force-pushed the bugfix/21213 branch 2 times, most recently from 6a8a2ab to b0b7b60 Compare June 27, 2024 11:52
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jul 1, 2024
@EduPonz
Copy link

EduPonz commented Jul 1, 2024

@Mergifyio backport 2.14.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 1, 2024 •
edited
Loading

backport 2.14.x

✅ Backports have been created

EduPonz
EduPonz suggested changes Jul 1, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM in general, but I think we need to adds some tests

thirdparty/dds-types-test Outdated Show resolved Hide resolved
@EduPonz
Copy link

EduPonz commented Jul 3, 2024

We have internally decided to not provide tests for this simple change

@richiware richiware requested a review from EduPonz July 3, 2024 08:23
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 3, 2024
@richiware richiware requested review from EduPonz and removed request for EduPonz July 3, 2024 08:55
@richiware
Refs #21213. Setting vendor_id on received CacheChange_t
529df84 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21213. Add info to versions.md
42f090c 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21213. Restore submodule
e60230c 
Signed-off-by: Ricardo González Moreno <[email protected]>
@EduPonz EduPonz removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Jul 4, 2024
@EduPonz
Copy link

EduPonz commented Jul 4, 2024

CI:

@EduPonz EduPonz merged commit 6c051ae into master Jul 4, 2024
3 checks passed
@EduPonz EduPonz deleted the bugfix/21213 branch July 4, 2024 08:51
mergify bot pushed a commit that referenced this pull request Jul 4, 2024
@richiware @mergify
Setting vendor_id on received CacheChange_t (#4978)
495ea92 
* Refs #21213. Setting vendor_id on received CacheChange_t

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21213. Add info to versions.md

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21213. Restore submodule

Signed-off-by: Ricardo González Moreno <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 6c051ae)

# Conflicts:
#	versions.md
@mergify mergify bot mentioned this pull request Jul 4, 2024
Merged
11 tasks
EduPonz pushed a commit that referenced this pull request Jul 9, 2024
@richiware
Setting vendor_id on received CacheChange_t (#4978)
c280137 
* Refs #21213. Setting vendor_id on received CacheChange_t

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21213. Add info to versions.md

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21213. Restore submodule

Signed-off-by: Ricardo González Moreno <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
(cherry picked from commit 6c051ae)

Signed-off-by: eduponz <[email protected]>
EduPonz pushed a commit that referenced this pull request Jul 10, 2024
@mergify @richiware
Setting vendor_id on received CacheChange_t (#4978) (#5030)
13f3003 
* Refs #21213. Setting vendor_id on received CacheChange_t



* Refs #21213. Add info to versions.md



* Refs #21213. Restore submodule



---------


(cherry picked from commit 6c051ae)

Signed-off-by: eduponz <[email protected]>
Co-authored-by: Ricardo González <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richiware @EduPonz @elianalf