-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting vendor_id on received CacheChange_t [21214] #4978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
6a8a2ab
to
b0b7b60
Compare
@Mergifyio backport 2.14.x |
✅ Backports have been created
|
EduPonz
suggested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM in general, but I think we need to adds some tests
We have internally decided to not provide tests for this simple change |
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
EduPonz
approved these changes
Jul 4, 2024
CI: |
mergify bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
* Refs #21213. Setting vendor_id on received CacheChange_t Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #21213. Add info to versions.md Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #21213. Restore submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> (cherry picked from commit 6c051ae) # Conflicts: # versions.md
11 tasks
EduPonz
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Refs #21213. Setting vendor_id on received CacheChange_t Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #21213. Add info to versions.md Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #21213. Restore submodule Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> (cherry picked from commit 6c051ae) Signed-off-by: eduponz <[email protected]>
EduPonz
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Refs #21213. Setting vendor_id on received CacheChange_t * Refs #21213. Add info to versions.md * Refs #21213. Restore submodule --------- (cherry picked from commit 6c051ae) Signed-off-by: eduponz <[email protected]> Co-authored-by: Ricardo González <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MessageReceiver
is setting the vendor _id for all RTPS submessages but forData
andDataFrag
. This PR sets the vendor_id for this last submessages.@Mergifyio backport 2.14.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist