Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNI support [15774] #2950

Merged
merged 5 commits into from
Sep 28, 2022
Merged

SNI support [15774] #2950

merged 5 commits into from
Sep 28, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Sep 12, 2022 •
edited by EduPonz
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: Add SNI documentation Fast-DDS-docs#404

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jparisu jparisu mentioned this pull request Sep 14, 2022
Closed
13 tasks
@EduPonz EduPonz added this to the v2.8.0 milestone Sep 21, 2022
@EduPonz EduPonz self-assigned this Sep 28, 2022
EduPonz
EduPonz suggested changes Sep 28, 2022
View reviewed changes
Copy link

@EduPonz EduPonz left a comment •
edited by jparisu
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, although before running a CI and approving, I'd like:

  • The uncrustify and DCO failures to be fixed.
  • The feature to be added to versions.md
  • Related documentation PR

@jparisu jparisu force-pushed the feature/sni branch 2 times, most recently from f6309d8 to 88cf0a2 Compare September 28, 2022 06:34
@jparisu
Copy link
Contributor Author

jparisu commented Sep 28, 2022

Related docs PR: eProsima/Fast-DDS-docs#404

@jparisu jparisu mentioned this pull request Sep 28, 2022
Merged
EduPonz
EduPonz previously approved these changes Sep 28, 2022
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz
Copy link

EduPonz commented Sep 28, 2022

@richiprosima please test this

@EduPonz EduPonz added the ci-pending PR which CI is running label Sep 28, 2022
@EduPonz
Copy link

EduPonz commented Sep 28, 2022

@richiprosima please test mac

1 similar comment
@EduPonz
Copy link

EduPonz commented Sep 28, 2022

@richiprosima please test mac

@EduPonz EduPonz force-pushed the feature/sni branch 2 times, most recently from 1121a92 to d061a59 Compare September 28, 2022 14:18
amitsingh21 and others added 5 commits September 28, 2022 19:57
@amitsingh21 @EduPonz
added support for setting sni_host in tcp transport descriptor
4ac6ffb 
Signed-off-by: jparisu <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Add server name to XML
d0c9f9c 
Signed-off-by: jparisu <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Add test
305f0a8 
Signed-off-by: jparisu <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
Add new feature to versions.md
6c60b46 
Signed-off-by: jparisu <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz
uncrustify
e3d45be 
Signed-off-by: jparisu <[email protected]>
Signed-off-by: Eduardo Ponz <[email protected]>
@EduPonz EduPonz added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Sep 28, 2022
@EduPonz EduPonz merged commit 9a6d215 into master Sep 28, 2022
@EduPonz EduPonz deleted the feature/sni branch September 28, 2022 18:00
@rsanchez15 rsanchez15 changed the title SNI support SNI support [15774] Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz left review comments

Assignees

@EduPonz EduPonz

Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jparisu @EduPonz @amitsingh21